Changed SearchRequest initializations to builder in code-sample
#567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uctor - Changed code-samples.meilisearch.yaml file, SearchRequestTest file and SearchTest file
alallema
added
the
maintenance
alallema
reviewed
Mar 6, 2023
There was a problem hiding this comment.
Thanks @PotatoDoge for this PR ❤️
I left a few comments. Also, we could change the SearchTest.java file but not the src/test/java/com/meilisearch/sdk/SearchRequestTest.java because we need to check if the initialization of SearchRequest work with both way with the builder and with the constructor.
Don't forget to run bash ./scripts/lint.sh for fixing the linter issues 😊
…ructor - Changed code-samples.meilisearch.yaml file, and SearchTest file - Fixed linting issues
|
@alallema thank you for the feedback! I believe that I fixed the issues. I'll wait for you to check it. :) |
alallema
approved these changes
Mar 6, 2023
alallema
changed the title
SearchRequest initializations to builder in code-sample
|
bors merge |
|
Build succeeded:
|
alallema
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed SearchRequest initializations to builder insted of a constructor
Pull Request
Related issue
Fixes #<560
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!