prototype-beta: Tokenizer customization #1563
Conversation
atoulmet
added
enhancement
atoulmet
force-pushed
the
prototype-beta/prototype-tokenizer-customization
branch
from
8a81d8c
to
774ef7b
Compare
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "meilisearch", | |||
| "version": "0.34.1", | |||
| "version": "0.34.2-tokenizer-customization.0", | |||
There was a problem hiding this comment.
@bidoubiwa do we really need to release a meilisearch-js beta? Should we test it with instant-meilisearch?
There was a problem hiding this comment.
Instant-meilisearch is not impacted by this new change!
I released it as it is part of the prototyping process, so that people can try it out. If you think it's not necessary, it is less work for us to not release it hehe
There was a problem hiding this comment.
Maybe the process is too complex for what we want to do
We just want to test the prototype is working with the library. Can we have a risk of not releasing it? I mean, can we have a difference of usage between using it from source, or by using the NPM package?
From my POV, releasing a NPM package is useful only if you want to use it with another library, like IS? Am I right?
For example, we will not release a beta for the PHP integration.
I also can understand sometimes it's useful for the users to test the beta version of the library however, especially for front end oriented features!
So I would say: if you agree, let's show the full process to @atoulmet (so release the beta version) even if it's not necessary, but in the future, we would rather go to simplicity and do only what is useful for us: ensuring the library can be compatible with the prototype.
There was a problem hiding this comment.
I mean, can we have a difference of usage between using it from source, or by using the NPM package?
No reasons there should be any difference.
From my POV, releasing a NPM package is useful only if you want to use it with another library, like IS? Am I right?
This would be the biggest reason. Another reason we had in the past is if we wanted users to be able to try the feature in their javascript environment without having to use a HTTP lib.
f you agree, let's show the full process to @atoulmet (so release the beta version) even if it's not necessary, but in the future, we would rather go to simplicity and do only what is useful for us: ensuring the library can be compatible with the prototype.
i completely agree!
atoulmet
force-pushed
the
prototype-beta/prototype-tokenizer-customization
branch
from
774ef7b
to
1441d4a
Compare
atoulmet
force-pushed
the
prototype-beta/prototype-tokenizer-customization
branch
from
1441d4a
to
223b252
Compare
brunoocasali
deleted the
prototype-beta/prototype-tokenizer-customization
branch
1578: Update version for the next release (v0.35.0) r=curquiza a=meili-bot ## CHANGELOG This version introduces features released on Meilisearch v1.4.0 🎉 Check out the changelog of [Meilisearch v1.4.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.4.0) for more information on the changes.⚠️ If you want to adopt new features of this release, **update the Meilisearch server** to the according version. ## 🚀 Enhancements - Add support for the new setting: `dictionary` (#1563) `@atoulmet` ```js client.index('books').getDictionary() client.index('books').updateDictionary(['W.E.B']) client.index('books').resetDictionary() ``` - Add support for the new setting: `separator-tokens` (#1563) `@atoulmet` ```js client.index('books').getSeparatorTokens() client.index('books').updateSeparatorTokens(['`@'])` client.index('books').resetSeparatorTokens() ``` - Add support for the new setting: `non-separator-tokens` (#1563) `@atoulmet` ```js client.index('books').getNonSeparatorTokens() client.index('books').updateNonSeparatorTokens(['.', ',']) client.index('books').resetNonSeparatorTokens() ``` ##⚠️ Warning usage with v1.4.0 A bug fix in Meilisearch v1.4.0 introduces a breaking change in the filter usage. It only concerns users using the `filter` search parameter with `\`. Explanation and change to apply are detailed in the [Meilisearch v1.4.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.4.0) Thanks to `@atoulmet` and `@bidoubiwa!` 🎉 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Pull Request
Related issue
Fixes #1555
Fixes #1556
What does this PR do?
Add dictionary settings:
Add separator tokens and non separator tokens settings:
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!