Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test by using an older version of jsdom #768

Merged
merged 2 commits into from Jan 25, 2021
Merged

Fix failing test by using an older version of jsdom #768

merged 2 commits into from Jan 25, 2021

Conversation

bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Jan 25, 2021 •
edited

Usage of jest-environment-jsdom is not explicitly given anywhere I searched for it. But it appears it creates a jest environment that uses (depending on the version) a previous jsdom.

More information on my supposition here: jestjs/jest#11025

Npm package of jest-environment-jsdom with 10million downloads a week but no readme https://www.npmjs.com/package/jest-environment-jsdom 馃く

@bidoubiwa bidoubiwa changed the title Fix failing test by using a older version of jsdom Fix failing test by using an older version of jsdom Jan 25, 2021
@bidoubiwa bidoubiwa marked this pull request as ready for review January 25, 2021 11:00
@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 25, 2021

Build succeeded:

@bors bors bot merged commit 2e41364 into master Jan 25, 2021
@bors bors bot deleted the fix_jsdom branch January 25, 2021 13:04
@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Jan 25, 2021
@bidoubiwa bidoubiwa mentioned this pull request Apr 28, 2021
Merged
bors bot added a commit that referenced this pull request Apr 28, 2021
@bors @bidoubiwa
Merge #885
d4d22a2 
885: Add jest environment and prettier in ignore dependabot file r=bidoubiwa a=bidoubiwa

see 
- #760
- #768


Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskombro eskombro eskombro approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bidoubiwa @eskombro @curquiza