Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes after the Node.js v10 EOL (2021-04-30) #760

Closed
2 tasks
curquiza opened this issue Jan 20, 2021 · 1 comment · Fixed by #914
Closed
2 tasks

Changes after the Node.js v10 EOL (2021-04-30) #760

curquiza opened this issue Jan 20, 2021 · 1 comment · Fixed by #914
Labels
dependencies Pull requests that update a dependency file
Projects
SDKs & Integrations

Comments

@curquiza
Copy link
Member

We need to:
@curquiza curquiza added dependencies Pull requests that update a dependency file SDK JS labels Jan 20, 2021
@curquiza curquiza added this to Open issues in SDKs & Integrations via automation Jan 20, 2021
@bidoubiwa
Copy link
Contributor

Remove following lib:

  • jest-environment-jsdom (yarn remove jest-environment-jsdom)

Edit the following file:

// ./jest.config.js
      testEnvironment: 'jest-environment-jsdom',

with the following

// ./jest.config.js
      testEnvironment: 'jsdom',

This was referenced Feb 9, 2021
Closed
Merged
bors bot added a commit to meilisearch/meilisearch-js-plugins that referenced this issue Feb 10, 2021
@bors @bidoubiwa
Merge #249
a9c7f6d 
249: Typescript first r=bidoubiwa a=bidoubiwa

# Typescript conversion

## Types update
Types have been improved and are compatible with instant search types.

## Linting update

All envs and playgrounds are linted based on the root eslint config file.

## Jest updates

as in meilisearch-js meilisearch/meilisearch-js#760 the jest jsdom had to be updated for the tests to succeed in node 10. #255

## Testing

Add build before tests for env tests using jest to succeed.
Add build of playgrounds in CI to determine if they correctly extract instant-meilisearch.
Add instantsearch.js as a dev dependency as it is used for testing purposes
Add some nodejs tests that tries instantsearch compatibility with instant-meilisearch
Add a typescript 

## Playgrounds

- Update playgrounds so that hot-reload also works on typescript files
- Remove sub-dir eslint configs as everything is handled by root eslint config file

## Naming

Methods inside instant-meilisearch function have been renamed for more clarity





Co-authored-by: Charlotte Vermandel <charlottevermandel@gmail.com>
@curquiza curquiza removed the SDK JS label Apr 14, 2021
@bidoubiwa bidoubiwa mentioned this issue Apr 28, 2021
Merged
bors bot added a commit that referenced this issue Apr 28, 2021
@bors @bidoubiwa
Merge #885
d4d22a2 
885: Add jest environment and prettier in ignore dependabot file r=bidoubiwa a=bidoubiwa

see 
- #760
- #768


Co-authored-by: cvermand <33010418+bidoubiwa@users.noreply.github.com>
This was referenced Jun 4, 2021
Closed
Closed
Merged
@bors bors bot closed this as completed in 5e336b2 Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
No open projects
SDKs & Integrations
Open issues
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove guaranteed compatibility with versions to 10> and 15< meilisearch/meilisearch-js
2 participants
@curquiza @bidoubiwa