Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.6] Support proximityPrecision setting #916

Closed
7 tasks
curquiza opened this issue Jan 15, 2024 · 2 comments · Fixed by #971
Closed
7 tasks

[v1.6] Support proximityPrecision setting #916

curquiza opened this issue Jan 15, 2024 · 2 comments · Fixed by #971
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@curquiza
Copy link
Member

Following this central issue

This is related to a newly introduced feature in Meilisearch v1.6.0: the proximity-precision setting.

Refer to docs for more information.

  • Add the new settings: proximityPrecision with get, update, and reset methods associated.
    Here are the JS equivalents in meilisearch-js you should create for this repository:
client.index('indexName').getProximityPrecision(); // calls GET /indexes/:uid/settings/proximity-precision
client.index('indexName').updateProximityPrecision('byAttribute');  // calls PUT /indexes/:uid/settings/proximity-precision
client.index('indexName').resetProximityPrecision(); // calls DELETE /indexes/:uid/settings/proximity-precision
@curquiza curquiza added enhancement New feature or request good first issue Good for newcomers labels Jan 15, 2024
@geeksambhu
Copy link
Contributor

@curquiza I want to work on this.

@curquiza
Copy link
Member Author

curquiza commented Feb 5, 2024

Thanks for your interest in this project 🔥 You are definitely more than welcome to open a PR for this!

For your information, we prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages the volunteer contributors from opening a PR to fix this issue.
We will accept and merge the first PR that fixes correctly and well implements the issue following our contributing guidelines.

We are looking forward to reviewing your PR 😊

meili-bors bot added a commit that referenced this issue Jun 5, 2024
971: Add proximityPrecision setting r=sanders41 a=the-sinner

# Pull Request

## Related issue
Fixes #916 

## What does this PR do?
- Add proximityPrecision setting

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Shalabh Agarwal <shalabhagarwal1024@gmail.com>
@meili-bors meili-bors bot closed this as completed in d273389 Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants