Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests related to the next Meilisearch release (v1.6.0) #900

Merged
merged 5 commits into from
Jan 15, 2024

Conversation

meili-bot
Copy link
Contributor

@meili-bot meili-bot commented Dec 26, 2023

Related to this issue: meilisearch/integration-guides#294

This PR:

  • gathers the changes related to the next Meilisearch release (v1.6.0) so that this package is ready when the official release is out.
  • should pass the tests against the latest pre-release of Meilisearch.
  • might eventually contain test failures until the Meilisearch v1.6.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

This PR is auto-generated for the pre-release week purpose.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc342ca) 100.00% compared to head (933fd3f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #900   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          752       752           
=========================================
  Hits           752       752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Jan 11, 2024
@curquiza curquiza marked this pull request as ready for review January 11, 2024 18:39
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

meili-bors bot added a commit that referenced this pull request Jan 15, 2024
900: Changes related to the next Meilisearch release (v1.6.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#294

This PR:
- gathers the changes related to the next Meilisearch release (v1.6.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.6.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: curquiza <clementine@meilisearch.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
Co-authored-by: Paul Sanders <psanders1@gmail.com>
@curquiza curquiza added maintenance Anything related to maintenance (CI, tests, refactoring...) and removed skip-changelog The PR will not appear in the release changelogs labels Jan 15, 2024
@curquiza curquiza changed the title Changes related to the next Meilisearch release (v1.6.0) Update tests related to the next Meilisearch release (v1.6.0) Jan 15, 2024
Copy link
Contributor

meili-bors bot commented Jan 15, 2024

Build failed:

@curquiza
Copy link
Member

Code coverage! I hate this tool!!! 😅

@curquiza
Copy link
Member

bors merge

meili-bors bot added a commit that referenced this pull request Jan 15, 2024
900: Update tests related to the next Meilisearch release (v1.6.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#294

This PR:
- gathers the changes related to the next Meilisearch release (v1.6.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.6.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: curquiza <clementine@meilisearch.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
Co-authored-by: Paul Sanders <psanders1@gmail.com>
Copy link
Contributor

meili-bors bot commented Jan 15, 2024

Build failed:

@curquiza
Copy link
Member

bors merge

meili-bors bot added a commit that referenced this pull request Jan 15, 2024
900: Update tests related to the next Meilisearch release (v1.6.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#294

This PR:
- gathers the changes related to the next Meilisearch release (v1.6.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.6.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.6.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: curquiza <clementine@meilisearch.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
Co-authored-by: Paul Sanders <psanders1@gmail.com>
Copy link
Contributor

meili-bors bot commented Jan 15, 2024

Build failed:

@sanders41
Copy link
Collaborator

Code coverage! I hate this tool!!! 😅

Yes! I have been fighting with it all day. I've looked for alternatives but so far I have not found anything.

@curquiza
Copy link
Member

@sanders41 do you agree I merge manually even if the tests are failing?

We can also remove completely code coverage until we find another working tool

cc: @brunoocasali

@sanders41
Copy link
Collaborator

@sanders41 do you agree I merge manually even if the tests are failing?

Yes, I agree. These failures are clearly codecov related and all the tests are passing.

@curquiza curquiza merged commit a464d39 into main Jan 15, 2024
13 of 17 checks passed
@curquiza curquiza deleted the bump-meilisearch-v1.6.0 branch January 15, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants