Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make embedders deseralize to correct type #927

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Make embedders deseralize to correct type #927

merged 3 commits into from
Feb 13, 2024

Conversation

sanders41
Copy link
Collaborator

Pull Request

Related issue

Fixes #926

What does this PR do?

  • Checks the model before deserializing to make sure the correct model is used.
  • Updates test to catch any potential regressions.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 added the bug Something isn't working label Feb 12, 2024
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tutto bene 🇮🇹

Thank you @sanders41

@curquiza
Copy link
Member

bors merge

Copy link
Contributor

meili-bors bot commented Feb 13, 2024

@meili-bors meili-bors bot merged commit 189381e into main Feb 13, 2024
11 checks passed
@meili-bors meili-bors bot deleted the get-embedders branch February 13, 2024 08:56
meili-bors bot added a commit that referenced this pull request Mar 11, 2024
928: Changes related to the next Meilisearch release (v1.7.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#296

This PR:
- gathers the changes related to the next Meilisearch release (v1.7.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.7.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.7.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


932: Update version for the next release (v0.31.0) r=curquiza a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-python to a new version: "v0.31.0"

---

Part of the work of #928

---

This version introduces features released on Meilisearch v1.7.0 🎉
Check out the changelog of [Meilisearch v1.7.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.7.0) for more information on the changes. 

## ⚠️ Breaking changes

* Related to the experimental `vectorStore` feature: `dimensions` field is now required when using OpenAI models.

## 🐛 Bug Fixes

* Make embedders deseralize to correct type (#927) sanders41

## ⚙️ Maintenance/misc

* Update author (#931) `@curquiza`


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Paul Sanders <psanders1@gmail.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
meili-bors bot added a commit that referenced this pull request Mar 11, 2024
932: Update version for the next release (v0.31.0) r=curquiza a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-python to a new version: "v0.31.0"

---

Part of the work of #928

---

This version introduces features released on Meilisearch v1.7.0 🎉
Check out the changelog of [Meilisearch v1.7.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.7.0) for more information on the changes. 

## ⚠️ Breaking changes

* Related to the experimental `vectorStore` feature: `dimensions` field is now required when using OpenAI models.

## 🐛 Bug Fixes

* Make embedders deseralize to correct type (#927) sanders41

## ⚙️ Maintenance/misc

* Update author (#931) `@curquiza`


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedders may deserialize to the wrong model when retrieving
2 participants