Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version for the next release (v0.31.0) #932

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

meili-bot
Copy link
Contributor

@meili-bot meili-bot commented Feb 16, 2024

This PR is auto-generated.

The automated script updates the version of meilisearch-python to a new version: "v0.31.0"


Part of the work of #928


This version introduces features released on Meilisearch v1.7.0 🎉
Check out the changelog of Meilisearch v1.7.0 for more information on the changes.

⚠️ Breaking changes

  • Related to the experimental vectorStore feature: dimensions field is now required when using OpenAI models.

🐛 Bug Fixes

⚙️ Maintenance/misc

@meili-bot meili-bot added the skip-changelog The PR will not appear in the release changelogs label Feb 16, 2024
@curquiza curquiza self-requested a review February 16, 2024 14:12
@curquiza curquiza marked this pull request as draft February 16, 2024 14:12
@sanders41
Copy link
Collaborator

sanders41 commented Feb 16, 2024

@curquiza the release for 1.7.0 will be breaking for vector search because the OpenAI model will send demensions which weren't available before. Vector search is experimental so 0.30.1 is fine, but with the last release we did a breaking for vector search. Do you want to do 0.31.0 to match the last release?

@curquiza
Copy link
Member

Is dimensions now mandatory for OpenAiEmbedder? I see Optional[int]
If yes, indeed, it's breaking because users of v1.6.0 will have to send dimensions now
But if it's not mandatory to use dimensions, I don't understand why it's breaking, because users who did not send dimensions can still continue to do the same

@sanders41
Copy link
Collaborator

It isn't manditry to set it, but when it sends to Meilisearch it includes dimensions: null in the json and Meilisearch <1.7 errors with that field present. I suppose we could strip the field off before sending if it is None and then it wouldn't be breaking.

@curquiza
Copy link
Member

curquiza commented Feb 16, 2024

It isn't manditry to set it, but when it sends to Meilisearch it includes dimensions: null in the json and Meilisearch <1.7 errors with that field present.

Got it! Thank you

As you wish. I'm ok with doing v0.31.0 instead of v0.30.1. Since it's experimental, I would recommend we don't patch too much our codebase to avoid breaking changes.

@sanders41
Copy link
Collaborator

I agree, there is less chance for error going forward if we don't patch and let this update be breaking.

meilisearch/version.py Outdated Show resolved Hide resolved
@curquiza curquiza changed the title Update version for the next release (v0.30.1) Update version for the next release (v0.31.0) Feb 16, 2024
@curquiza curquiza self-requested a review February 16, 2024 14:57
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@curquiza curquiza marked this pull request as ready for review March 11, 2024 12:56
meili-bors bot added a commit that referenced this pull request Mar 11, 2024
928: Changes related to the next Meilisearch release (v1.7.0) r=curquiza a=meili-bot

Related to this issue: meilisearch/integration-guides#296

This PR:
- gathers the changes related to the next Meilisearch release (v1.7.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v1.7.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.7.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._


932: Update version for the next release (v0.31.0) r=curquiza a=meili-bot

_This PR is auto-generated._

The automated script updates the version of meilisearch-python to a new version: "v0.31.0"

---

Part of the work of #928

---

This version introduces features released on Meilisearch v1.7.0 🎉
Check out the changelog of [Meilisearch v1.7.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.7.0) for more information on the changes. 

## ⚠️ Breaking changes

* Related to the experimental `vectorStore` feature: `dimensions` field is now required when using OpenAI models.

## 🐛 Bug Fixes

* Make embedders deseralize to correct type (#927) sanders41

## ⚙️ Maintenance/misc

* Update author (#931) `@curquiza`


Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Co-authored-by: Paul Sanders <psanders1@gmail.com>
Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
Copy link
Contributor

meili-bors bot commented Mar 11, 2024

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@curquiza
Copy link
Member

bors merge

Copy link
Contributor

meili-bors bot commented Mar 11, 2024

@meili-bors meili-bors bot merged commit 948b1d0 into main Mar 11, 2024
11 checks passed
@meili-bors meili-bors bot deleted the meili-bot/bump-version branch March 11, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants