Split spec/support/active_record_classes.rb
#342
Conversation
ellnix
added
skip-changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
=======================================
Coverage 90.22% 90.22%
=======================================
Files 13 13
Lines 757 757
=======================================
Hits 683 683
Misses 74 74 ☔ View full report in Codecov by Sentry. |
ellnix
force-pushed
the
split-integration-spec
branch
from
fbe9e48
to
a4c1d13
Compare
| ActiveJob::Base.queue_adapter = :test | ||
| end | ||
|
|
||
| def ar_schema |
There was a problem hiding this comment.
This method is responsible for decentralizing ActiveRecord::Schema.define.
Since the old define method mainly instance_exec'ed the block provided to it, this should be fine (define also updated some metadata tables but they should not be necessary for us).
| @@ -0,0 +1,33 @@ | |||
| require 'support/active_record_schema' | |||
There was a problem hiding this comment.
These requires I thought would make it obvious where ar_schema comes from, so it's easier to follow the logic in an integration spec from
require 'support/models/<model>
to
require 'support/active_record_schema
in a few clicks and get a grasp of what is happening.
ellnix
changed the title
spec/support/active_record_classes.rb
Debated removing this model entirely.
There was a problem hiding this comment.
LGTM! Very good work @ellnix
That's the perfect balance between the size of the PR and the changes itself. Very easy to grasp what's going on.
Keep going 🤘
|
bors merge |
A first step toward #332