Add tests to custom search with matching_strategy param
#364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
force-pushed
the
add-tests-to-matching
branch
from
8b53a08
to
db88115
Compare
mdubus
reviewed
Sep 5, 2022
| @@ -0,0 +1,17 @@ | |||
| # frozen_string_literal: true | |||
There was a problem hiding this comment.
I don't understand this comment :) Why is it here and what is it?
There was a problem hiding this comment.
I found something on Stackoverflow: https://stackoverflow.com/questions/37799296/ruby-what-does-the-comment-frozen-string-literal-true-do
My tutor during my first internship also told me it was more performant. Maybe @brunoocasali will be able to say if it's true or not haha
There was a problem hiding this comment.
Yeaah, that's correct with this magic comment. You will save memory because you don't need to allocate more space to store the same string.
In Ruby 3.0. Matz (Ruby’s creator) decided to make all String literals frozen by default.
curquiza
approved these changes
Sep 5, 2022
meili-bors bot
added a commit
that referenced
this pull request
Sep 20, 2022
366: Update version for the next release (v0.20.0) r=brunoocasali a=brunoocasali This version makes this package compatible with Meilisearch v0.29.0 🎉 Check out the changelog of [Meilisearch v0.29.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.29.0) for more information on the changes. ## 🚀 Enhancements - Ensure support to the new search query parameter `matchingStrategy` (#364) `@brunoocasali` - Ensure support to keys with wildcarded actions. - `actions` field during key creation now accepts wildcards on actions. For example, `indexes.*` provides rights to `indexes.create`, `indexes.get`,`indexes.delete`, `indexes.delete`, and `indexes.update`. (#365) `@brunoocasali` ##⚠️ Breaking Changes This breaking change *__may not affect you__*, but in any case, you should check your search queries if you want to keep the same behavior from `v0.28`. - The `NOT` filter keyword does not have an implicitly `EXIST` operator anymore. Check out for more information: meilisearch/meilisearch#2486 Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
meili-bors bot
added a commit
that referenced
this pull request
Oct 3, 2022
366: Update version for the next release (v0.20.0) r=curquiza a=brunoocasali This version makes this package compatible with Meilisearch v0.29.0 🎉 Check out the changelog of [Meilisearch v0.29.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.29.0) for more information on the changes. ## 🚀 Enhancements - Ensure support to the new search query parameter `matchingStrategy` (#364) `@brunoocasali` - Ensure support to keys with wildcarded actions. - `actions` field during key creation now accepts wildcards on actions. For example, `indexes.*` provides rights to `indexes.create`, `indexes.get`,`indexes.delete`, `indexes.delete`, and `indexes.update`. (#365) `@brunoocasali` ##⚠️ Breaking Changes This breaking change *__may not affect you__*, but in any case, you should check your search queries if you want to keep the same behavior from `v0.28`. - The `NOT` filter keyword does not have an implicitly `EXIST` operator anymore. Check out for more information: meilisearch/meilisearch#2486 Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the support of
matching_strategyquery parameter.