Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to wildcarded action keys #365

Merged
merged 1 commit into from Sep 5, 2022

Conversation

brunoocasali
Copy link
Member

Ensure support to keys with wildcarded actions.

  • actions field during key creation now accepts wildcards on actions. For example, indexes.* provides rights to indexes.create, indexes.get,indexes.delete, indexes.delete, and indexes.update.

@brunoocasali brunoocasali added the enhancement New feature or request label Sep 2, 2022
@brunoocasali brunoocasali changed the base branch from main to bump-meilisearch-v0.29.0 September 2, 2022 17:51
@brunoocasali brunoocasali changed the title Add tests to global keys Add tests to wildcarded action keys Sep 2, 2022
Copy link
Member

@mdubus mdubus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@brunoocasali brunoocasali merged commit 3234ff6 into bump-meilisearch-v0.29.0 Sep 5, 2022
@brunoocasali brunoocasali deleted the add-tests-to-global-keys branch September 5, 2022 14:28
meili-bors bot added a commit that referenced this pull request Sep 20, 2022
366: Update version for the next release (v0.20.0) r=brunoocasali a=brunoocasali

This version makes this package compatible with Meilisearch v0.29.0 🎉
Check out the changelog of [Meilisearch v0.29.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.29.0) for more information on the changes.

## 🚀 Enhancements

- Ensure support to the new search query parameter `matchingStrategy` (#364) `@brunoocasali` 
- Ensure support to keys with wildcarded actions.
  - `actions` field during key creation now accepts wildcards on actions. For example, `indexes.*` provides rights to `indexes.create`, `indexes.get`,`indexes.delete`, `indexes.delete`, and `indexes.update`. (#365) `@brunoocasali` 
  
## ⚠️ Breaking Changes

This breaking change *__may not affect you__*, but in any case, you should check your search queries if you want to keep the same behavior from `v0.28`.

- The `NOT` filter keyword does not have an implicitly `EXIST` operator anymore. Check out for more information: meilisearch/meilisearch#2486

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
meili-bors bot added a commit that referenced this pull request Oct 3, 2022
366: Update version for the next release (v0.20.0) r=curquiza a=brunoocasali

This version makes this package compatible with Meilisearch v0.29.0 🎉
Check out the changelog of [Meilisearch v0.29.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.29.0) for more information on the changes.

## 🚀 Enhancements

- Ensure support to the new search query parameter `matchingStrategy` (#364) `@brunoocasali` 
- Ensure support to keys with wildcarded actions.
  - `actions` field during key creation now accepts wildcards on actions. For example, `indexes.*` provides rights to `indexes.create`, `indexes.get`,`indexes.delete`, `indexes.delete`, and `indexes.update`. (#365) `@brunoocasali` 
  
## ⚠️ Breaking Changes

This breaking change *__may not affect you__*, but in any case, you should check your search queries if you want to keep the same behavior from `v0.28`.

- The `NOT` filter keyword does not have an implicitly `EXIST` operator anymore. Check out for more information: meilisearch/meilisearch#2486

Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants