Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the comment to ignore PHP Stan #158

Closed
curquiza opened this issue Jan 31, 2022 · 2 comments · Fixed by #161 or #185
Closed

Remove the comment to ignore PHP Stan #158

curquiza opened this issue Jan 31, 2022 · 2 comments · Fixed by #161 or #185
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@curquiza
Copy link
Member

Added here: https://github.com/meilisearch/meilisearch-symfony/pull/137/files#r795918289

We might want to find a way to make PHPStan happy without adding a comment to ignore the line
@curquiza curquiza added enhancement New feature or request good first issue Good for newcomers labels Jan 31, 2022
@curquiza curquiza mentioned this issue Jan 31, 2022
Merged
@norkunas norkunas mentioned this issue Feb 7, 2022
Merged
3 tasks
@bors bors bot closed this as completed in fc6a53f Feb 8, 2022
@brunoocasali
Copy link
Member

Since we just "moved" the phpstan ignore to another place, we must keep this open! 👯

@brunoocasali brunoocasali reopened this Feb 8, 2022
@althaus
Copy link
Contributor

althaus commented Jun 22, 2022

The issue is a mix-up of the ClassMetadata classes:

Doctrine\ORM\Mapping\ClassMetada

vs

Doctrine\Persistence\Mapping\ClassMetada

So it's expecting the one and gets the other. I'll prepare a PR to fix this.

althaus added a commit to althaus/meilisearch-symfony that referenced this issue Jun 23, 2022
@althaus
Fixed ClassMetadata usage in SearchableEntity (fixes meilisearch#158)
afc99d2
@althaus althaus mentioned this issue Jun 23, 2022
Merged
3 tasks
althaus added a commit to althaus/meilisearch-symfony that referenced this issue Jun 23, 2022
@althaus
Fixed ClassMetadata usage in SearchableEntity (fixes meilisearch#158)
b491f3f
bors bot added a commit that referenced this issue Jun 27, 2022
@bors @althaus
Merge #185
3c13cbc 
185: Fixed ClassMetadata usage in SearchableEntity (fixes #158) r=brunoocasali a=althaus

# Pull Request

## What does this PR do?
Fixes #158

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Matthias Althaus <kontakt@althaus.it>
@bors bors bot closed this as completed in 49ccb44 Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@althaus @brunoocasali @curquiza