Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update php cs fixer 3 #83

Merged
merged 2 commits into from May 21, 2021
Merged

Update php cs fixer 3 #83

merged 2 commits into from May 21, 2021

Conversation

codedge
Copy link
Contributor

@codedge codedge commented May 12, 2021

This PR adds support for the new PHP CS Fixer 3 version.

@codedge
Copy link
Contributor Author

codedge commented May 12, 2021

@curquiza Do I call bors m e r g e or what's the plan? 😅

@codedge codedge requested a review from curquiza May 12, 2021 17:19
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codedge!

Don't worry you don't have the access to merge with bors, only the MeiliSearch team members can.
However, you can bors try to check your PR will pass if we do a bors merge.
A bors try is only useful if your branch is not up-to-date with main otherwise the GH check already show you the validity of your PR 🙂
I wrote a guide about our bors usage: https://github.com/meilisearch/integration-guides/blob/main/guides/bors.md

@curquiza
Copy link
Member

bors merge

@curquiza
Copy link
Member

(seems like bors has trouble at the moment 😂)

@curquiza
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented May 21, 2021

@bors bors bot merged commit 9e34254 into main May 21, 2021
@bors bors bot deleted the update-php-cs-fixer-3 branch May 21, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants