Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url api key config #84

Merged
merged 3 commits into from May 21, 2021
Merged

Add url api key config #84

merged 3 commits into from May 21, 2021

Conversation

codedge
Copy link
Contributor

@codedge codedge commented May 12, 2021

Currently the URL and API_KEY was read via %env(MEILISEARCH_URL)% in services.xml. This does not fulfill the requirements for a Symfony recipe - see PR.

This PR moves the configuration of url and api_key into the config/meili_search.yml file, and references the env helper %env(MEILISEARCH_URL)% and %env(MEILISEARCH_API_KEY)% in there.

This is a breaking change, as the config now must look like:

meili_search:
  url: '%env(MEILISEARCH_URL)%'
  api_key: '%env(MEILISEARCH_API_KEY)%'
  prefix: '%env(MEILISEARCH_PREFIX)%'
  # Further settings

... see url and api_key.

For existing projects these two keys need to be added to the config manually. When the Symfony recipe is approved thise file will be created automatically and populated with the necessary values.

Holger Lösken added 2 commits May 12, 2021 19:54
@codedge codedge added the breaking-change The related changes are breaking for the users label May 12, 2021
@codedge codedge requested a review from curquiza May 12, 2021 19:58
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @codedge! Sorry for the delay, I was not available at all the previous week :)
I updated this page of our Wiki according to the breaking changes in this PR: https://github.com/meilisearch/meilisearch-symfony/wiki/Index-Configuration

Tell me if my changes are correct for you.
Feel free to update or add any page you want in this wiki of course. If I'm correct, you have the right to do it.

Thanks a lot for this PR!!

@curquiza
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented May 21, 2021

@bors bors bot merged commit fc1ea6e into main May 21, 2021
@bors bors bot deleted the add-url-api-key-config branch May 21, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants