Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jms serializer #93

Merged
merged 2 commits into from Jun 21, 2021
Merged

Remove jms serializer #93

merged 2 commits into from Jun 21, 2021

Conversation

codedge
Copy link
Contributor

@codedge codedge commented Jun 20, 2021

This PR remove the jms/serializer package. The serializer used by melisearch-symfony is Symfonys Serializer Component.

I think the usage of jms/serilaizer was a left-over from somewhen, as the normalizer cannot be different to the NormalizerInterface coming from Symfonys component.

Further the jms/serializer component was added in the require-dev section which indicates that the package was used for testing/developing purposes. I wasn't able to spot any usage.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @codedge!!! 😄

@curquiza
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 21, 2021

@bors bors bot merged commit a2b64b7 into main Jun 21, 2021
@bors bors bot deleted the remov-jms-serializer branch June 21, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants