-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New highlight style #139
Comments
curquiza
pushed a commit
that referenced
this issue
Jun 30, 2021
139: Fix commit date & SHA in startup message r=MarinPostma a=shekhirin Resolves meilisearch/transplant#137 Resolves meilisearch/transplant#138 --- I ran a GitHub Action towards my own dockerhub: https://github.com/shekhirin/transplant/actions/runs/732666353 Startup message now shows correct `Commit SHA` and `Commit date` (changed from `Build date`). ```console ➜ transplant (shekhirin/startup-git-vars) ✔ docker run -it -p 7700:7700 shekhirin/meilisearch:v0.21.0-alpha.2 ./meilisearch --no-analytics=true Unable to find image 'shekhirin/meilisearch:v0.21.0-alpha.2' locally v0.21.0-alpha.2: Pulling from shekhirin/meilisearch bfdacc68c91b: Already exists 73b1ed30fa0b: Pull complete 6607217ed754: Pull complete Digest: sha256:31bd6ac37e8711ab9d4123cf2ba2f942686569f08d68cfed8643752f381bfb74 Status: Downloaded newer image for shekhirin/meilisearch:v0.21.0-alpha.2 888b d888 d8b 888 d8b .d8888b. 888 8888b d8888 Y8P 888 Y8P d88P Y88b 888 88888b.d88888 888 Y88b. 888 888Y88888P888 .d88b. 888 888 888 "Y888b. .d88b. 8888b. 888d888 .d8888b 88888b. 888 Y888P 888 d8P Y8b 888 888 888 "Y88b. d8P Y8b "88b 888P" d88P" 888 "88b 888 Y8P 888 88888888 888 888 888 "888 88888888 .d888888 888 888 888 888 888 " 888 Y8b. 888 888 888 Y88b d88P Y8b. 888 888 888 Y88b. 888 888 888 888 "Y8888 888 888 888 "Y8888P" "Y8888 "Y888888 888 "Y8888P 888 888 Database path: "./data.ms" Server listening on: "http://0.0.0.0:7700" Environment: "development" Commit SHA: "038f1c740198f974743ba87fce7b74a8d0b71b5c" Commit date: "2021-04-09" Package version: "0.21.0-alpha.2" Sentry DSN: "https://5ddfa22b95f241198be2271aaf028653@sentry.io/3060337" Anonymous telemetry: "Disabled" No master key found; The server will accept unidentified requests. If you need some protection in development mode, please export a key: export MEILI_MASTER_KEY=xxx Documentation: https://docs.meilisearch.com Source code: https://github.com/meilisearch/meilisearch Contact: https://docs.meilisearch.com/resources/contact.html or bonjour@meilisearch.com [2021-04-09T10:29:49Z INFO actix_server::builder] Starting 2 workers [2021-04-09T10:29:49Z INFO actix_server::builder] Starting "actix-web-service-0.0.0.0:7700" service on 0.0.0.0:7700 [2021-04-09T10:29:49Z INFO meilisearch_http::index_controller::uuid_resolver::actor] uuid resolver started [2021-04-09T10:29:49Z INFO meilisearch_http::index_controller::update_actor::actor] Started update actor. ``` Endpoint also works as expected (`buildDate` -> `commitDate`) ```console ➜ transplant (shekhirin/startup-git-vars) ✔ curl http://localhost:7700/version {"commitSha":"038f1c740198f974743ba87fce7b74a8d0b71b5c","commitDate":"2021-04-09","pkgVersion":"0.21.0-alpha.2"} ``` Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the engine returns for highlights the fields name, the start of the occurrence and the length.
e.g.
It should be great to have the content of the field with the highlights visible. Set a text before and after the highlight. It should be great for many usages. Like rendering HTML, printing on a terminal, etc. But keep the information starts and length of a match is also interesting in some case.
e.g.
The text was updated successfully, but these errors were encountered: