Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the milli's heed dependency #2210

Closed
2 tasks done
curquiza opened this issue Mar 7, 2022 · 2 comments · Fixed by #2228
Closed
2 tasks done

Use the milli's heed dependency #2210

curquiza opened this issue Mar 7, 2022 · 2 comments · Fixed by #2228
Assignees
@Kerollmops
Labels
enhancement New feature or improvement good first issue Good for newcomers milli Related to the milli workspace v0.27.0 PRs/issues solved in v0.27.0
Milestone
v0.27.0

Comments

@curquiza
Copy link
Member

curquiza commented Mar 7, 2022 •
edited

Discussed with @Kerollmops
As we did for the tokenizer, we want to use the heed dependency from Milli's side to avoid having different versions of Heed in Meilisearch. Indeed compilation will fail if we have different versions of heed in Meilisearch and in Milli.

  • Export heed on Milli's side
  • Use the exported Heed dependency in Meilisearch
@curquiza curquiza added enhancement New feature or improvement good first issue Good for newcomers milli Related to the milli workspace labels Mar 7, 2022
@curquiza curquiza added this to the v0.27.0 milestone Mar 7, 2022
psvnlsaikumar added a commit to psvnlsaikumar/meilisearch that referenced this issue Mar 13, 2022
@psvnlsaikumar
updates to Use the milli's heed dependency meilisearch#2210
22a4eb5
@psvnlsaikumar psvnlsaikumar mentioned this issue Mar 13, 2022
Merged
3 tasks
@curquiza curquiza linked a pull request Mar 14, 2022 that will close this issue
Use the milli's heed dependency #2228
Merged
3 tasks
@curquiza
Copy link
Member Author

I assign @Kerollmops responsible for reviewing and merging the contributor PR :)

@irevoire irevoire mentioned this issue Mar 14, 2022
Merged
3 tasks
bors bot added a commit to meilisearch/milli that referenced this issue Mar 14, 2022
@bors @psvnlsaikumar
Merge #464
f430109 
464: exporting heed to avoid having different versions of Heed in Meilisearch r=Kerollmops a=psvnlsaikumar

# Pull Request

## What does this PR do?
Fixes the issue in meilisearch meilisearch/meilisearch#2210

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: psvnl sai kumar <psvnlsaikumar@gmail.com>
bors bot added a commit to meilisearch/milli that referenced this issue Mar 14, 2022
@bors @psvnlsaikumar
Merge #464
9bba79d 
464: exporting heed to avoid having different versions of Heed in Meilisearch r=Kerollmops a=psvnlsaikumar

# Pull Request

## What does this PR do?
Fixes the issue in meilisearch meilisearch/meilisearch#2210

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: psvnl sai kumar <psvnlsaikumar@gmail.com>
bors bot added a commit to meilisearch/milli that referenced this issue Mar 14, 2022
@bors @psvnlsaikumar
Merge #464
e5ecb04 
464: exporting heed to avoid having different versions of Heed in Meilisearch r=curquiza a=psvnlsaikumar

# Pull Request

## What does this PR do?
Fixes the issue in meilisearch meilisearch/meilisearch#2210

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: psvnl sai kumar <psvnlsaikumar@gmail.com>
bors bot added a commit to meilisearch/milli that referenced this issue Mar 15, 2022
@bors @psvnlsaikumar
Merge #464
712bf03 
464: exporting heed to avoid having different versions of Heed in Meilisearch r=curquiza a=psvnlsaikumar

# Pull Request

## What does this PR do?
Fixes the issue in meilisearch meilisearch/meilisearch#2210

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: psvnl sai kumar <psvnlsaikumar@gmail.com>
MarinPostma pushed a commit that referenced this issue Mar 16, 2022
@psvnlsaikumar
chore(all): use re-exported heed dependency from milli
bdaf729 
* updates to Use the milli's heed dependency #2210

* Update index.rs

* Update store.rs

* Update mod.rs

* cargo fmt
@MarinPostma MarinPostma mentioned this issue Mar 16, 2022
Merged
MarinPostma pushed a commit that referenced this issue Mar 16, 2022
@psvnlsaikumar @MarinPostma
chore(all): use re-exported heed dependency from milli
92281b6 
* updates to Use the milli's heed dependency #2210

* Update index.rs

* Update store.rs

* Update mod.rs

* cargo fmt
MarinPostma pushed a commit that referenced this issue Mar 16, 2022
@psvnlsaikumar @MarinPostma
chore(all): bump milli
c24867e 
* updates to Use the milli's heed dependency #2210

* Update index.rs

* Update store.rs

* Update mod.rs

* cargo fmt
MarinPostma pushed a commit that referenced this issue Mar 16, 2022
@psvnlsaikumar @MarinPostma
chore(all): bump milli
e271395 
* updates to Use the milli's heed dependency #2210

* Update index.rs

* Update store.rs

* Update mod.rs

* cargo fmt
@curquiza
Copy link
Member Author

Closed by #2228 and #2244

@curquiza curquiza added the v0.27.0 PRs/issues solved in v0.27.0 label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kerollmops Kerollmops

Labels
enhancement New feature or improvement good first issue Good for newcomers milli Related to the milli workspace v0.27.0 PRs/issues solved in v0.27.0
Projects
None yet
Milestone
v0.27.0
Development

Successfully merging a pull request may close this issue.

Use the milli's heed dependency psvnlsaikumar/meilisearch
2 participants
@Kerollmops @curquiza