Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

exporting heed to avoid having different versions of Heed in Meilisearch #464

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

psvnlsaikumar
Copy link
Contributor

@psvnlsaikumar psvnlsaikumar commented Mar 13, 2022

Pull Request

What does this PR do?

Fixes the issue in meilisearch meilisearch/meilisearch#2210

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, merging!
bors merge

bors bot added a commit that referenced this pull request Mar 14, 2022
464: exporting heed to avoid having different versions of Heed in Meilisearch r=Kerollmops a=psvnlsaikumar

# Pull Request

## What does this PR do?
Fixes the issue in meilisearch meilisearch/meilisearch#2210

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: psvnl sai kumar <psvnlsaikumar@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 14, 2022

Build failed:

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, could you do a rustfmt pass, please?

cargo +nightly fmt

@psvnlsaikumar
Copy link
Contributor Author

@Kerollmops Performed cargo +nightly fmt . I hope that this was the expectation.

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thank you!
bors merge

bors bot added a commit that referenced this pull request Mar 14, 2022
464: exporting heed to avoid having different versions of Heed in Meilisearch r=Kerollmops a=psvnlsaikumar

# Pull Request

## What does this PR do?
Fixes the issue in meilisearch meilisearch/meilisearch#2210

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: psvnl sai kumar <psvnlsaikumar@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 14, 2022

Timed out.

@curquiza
Copy link
Member

bors merge

bors bot added a commit that referenced this pull request Mar 14, 2022
464: exporting heed to avoid having different versions of Heed in Meilisearch r=curquiza a=psvnlsaikumar

# Pull Request

## What does this PR do?
Fixes the issue in meilisearch meilisearch/meilisearch#2210

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: psvnl sai kumar <psvnlsaikumar@gmail.com>
@bors
Copy link
Contributor

bors bot commented Mar 14, 2022

Timed out.

@curquiza
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

@bors bors bot merged commit 712bf03 into meilisearch:main Mar 15, 2022
@Kerollmops Kerollmops added the DB breaking The related changes break the DB label Mar 16, 2022
@Kerollmops
Copy link
Member

This PR is breaking as, even if it is the same version as before, cargo/rustc is not smart enough to understand that and makes calling crates break.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DB breaking The related changes break the DB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants