Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and stabilize cropping and highlighting #2214

Closed
5 of 6 tasks
curquiza opened this issue Mar 7, 2022 · 5 comments · Fixed by #2297
Closed
5 of 6 tasks

Improve and stabilize cropping and highlighting #2214

curquiza opened this issue Mar 7, 2022 · 5 comments · Fixed by #2297
Assignees
@ManyTheFish
Labels
enhancement New feature or improvement impacts docs This issue involves changes in the Meilisearch's documentation impacts integrations This issue involves changes in the Meilisearch's integrations v0.27.0 PRs/issues solved in v0.27.0
Milestone
v0.27.0

Comments

@curquiza
Copy link
Member

curquiza commented Mar 7, 2022 •
edited

Here is the spec: meilisearch/specifications#120

More information is coming once the spec is stabilized.

Implementation

Pull requests

checklist
@curquiza curquiza added enhancement New feature or improvement tracking issue Tracks development of a global issue impacts docs This issue involves changes in the Meilisearch's documentation impacts integrations This issue involves changes in the Meilisearch's integrations labels Mar 7, 2022
@curquiza curquiza added this to the v0.27.0 milestone Mar 7, 2022
@curquiza
Copy link
Member Author

curquiza commented Mar 7, 2022

Pinging @meilisearch/integration-team and @meilisearch/docs-team. The spec is still a WIP, I will let you know when we'll have some updates.

@curquiza curquiza removed the tracking issue Tracks development of a global issue label Mar 9, 2022
@brunoocasali brunoocasali mentioned this issue Apr 6, 2022
Closed
@ManyTheFish ManyTheFish mentioned this issue Apr 7, 2022
Merged
6 tasks
@curquiza curquiza mentioned this issue Apr 7, 2022
Closed
@curquiza
Copy link
Member Author

curquiza commented Apr 7, 2022

@meilisearch/integration-team and @meilisearch/docs-team: the smart crop is officially delayed to v0.28.0. All the other planned features are present.

A new issue has been open to handle the smart crop planned in v0.28.0: #2299

@bors bors bot closed this as completed in 013fe4c Apr 7, 2022
@bors bors bot closed this as completed in #2297 Apr 7, 2022
@brunoocasali
Copy link
Member

Thanks for the information @curquiza 🥇

@guimachiavelli
Copy link
Member

So cropping will keep its current behaviour: find the first occurrence of a search term and crop X amount of words starting from there, correct?

@curquiza
Copy link
Member Author

Yes @guimachiavelli! :) the change of behavior will be for v0.28.0

@bidoubiwa bidoubiwa mentioned this issue Apr 13, 2022
Merged
This was referenced Apr 20, 2022
Merged
Merged
@brunoocasali brunoocasali mentioned this issue Apr 26, 2022
Merged
@bidoubiwa bidoubiwa mentioned this issue Apr 26, 2022
Merged
@alallema alallema mentioned this issue Apr 26, 2022
Merged
@bidoubiwa bidoubiwa mentioned this issue Apr 26, 2022
Merged
@alallema alallema mentioned this issue Apr 27, 2022
Merged
bors bot added a commit to meilisearch/meilisearch-go that referenced this issue May 3, 2022
@bors @alallema
Merge #291
21081fd 
291: Add new search parameters highlightPreTag, highlightPostTag and cropMarker r=alallema a=alallema

As per meilisearch/meilisearch#2214 new search parameters are introduced: 

- `highlightPreTag`
- `highlightPostTag`
- `cropMarker`


Co-authored-by: alallema <amelie@meilisearch.com>
Co-authored-by: Amélie <alallema@users.noreply.github.com>
This was referenced May 4, 2022
Merged
Merged
@curquiza curquiza added the v0.27.0 PRs/issues solved in v0.27.0 label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ManyTheFish ManyTheFish

Labels
enhancement New feature or improvement impacts docs This issue involves changes in the Meilisearch's documentation impacts integrations This issue involves changes in the Meilisearch's integrations v0.27.0 PRs/issues solved in v0.27.0
Projects
None yet
Milestone
v0.27.0
Development

Successfully merging a pull request may close this issue.

Feat(Search): Enhance formating search results meilisearch/meilisearch
4 participants
@guimachiavelli @brunoocasali @ManyTheFish @curquiza