Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MEILI-RC Wrong error code returned #3753

Closed
irevoire opened this issue May 15, 2023 · 1 comment · Fixed by #3759
Closed

MEILI-RC Wrong error code returned #3753

irevoire opened this issue May 15, 2023 · 1 comment · Fixed by #3759
Assignees
@irevoire
Labels
bug Something isn't working as expected v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05
Milestone
v1.2.0

Comments

@irevoire
Copy link
Member

irevoire commented May 15, 2023 •
edited

Describe the bug
When trying to delete documents by a filter, if everything is well-formed except the attribute is not filterable. The « original » error code coming from milli stays invalid_search_filter; we should patch it.

I think there is already a test for this specific case; I just wrote so many tests at once that I didn't realize it was wrong.

Meilisearch version:
latest rc

This was introduced by this release
@irevoire irevoire added the bug Something isn't working as expected label May 15, 2023
@irevoire irevoire added this to the v1.2.0 milestone May 15, 2023
@irevoire irevoire self-assigned this May 16, 2023
@irevoire irevoire mentioned this issue May 16, 2023
Merged
@irevoire irevoire linked a pull request May 16, 2023 that will close this issue
Invalid error code when parsing filters #3759
Merged
meili-bors bot added a commit that referenced this issue May 16, 2023
@meili-bors @irevoire
Merge #3759
4d037e6 
3759: Invalid error code when parsing filters r=dureuill a=irevoire

# Pull Request

## Related issue
Fixes #3753

## What does this PR do?
Fix the error code in case the error comes from the evaluate of the filter for the get, fetch and delete documents routes.


Co-authored-by: Tamo <tamo@meilisearch.com>
@curquiza
Copy link
Member

Fixed by #3759
will be released in rc1 during this week

@meili-bot meili-bot added the v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05 label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irevoire irevoire

Labels
bug Something isn't working as expected v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Invalid error code when parsing filters meilisearch/meilisearch
3 participants
@irevoire @curquiza @meili-bot