Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last error code changes on the new get/delete documents routes #3774

Closed
irevoire opened this issue May 24, 2023 · 1 comment · Fixed by #3775
Closed

Last error code changes on the new get/delete documents routes #3774

irevoire opened this issue May 24, 2023 · 1 comment · Fixed by #3775
Assignees
@irevoire
Labels
error handler Issues related to the returned errors in Meilisearch impacts docs This issue involves changes in the Meilisearch's documentation impacts integrations This issue involves changes in the Meilisearch's integrations v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05
Milestone
v1.2.0

Comments

@irevoire
Copy link
Member

Related spec: meilisearch/specifications#236

Motivation

Implement the last changes proposed in the specification:

  1. Get rid of the invalid_document_delete_filter and always use the invalid_document_filter
  2. Introduce a new missing_document_filter instead of returning invalid_document_delete_filter (that’s consistent with all the other routes that have a mandatory parameter)
  3. Always return the original_filter in the details (potentially set to null) instead of hiding it if it wasn’t used

Impacted teams

@meilisearch/docs-team @meilisearch/integration-team
@irevoire irevoire added impacts docs This issue involves changes in the Meilisearch's documentation impacts integrations This issue involves changes in the Meilisearch's integrations error handler Issues related to the returned errors in Meilisearch labels May 24, 2023
@irevoire irevoire added this to the v1.2.0 milestone May 24, 2023
@irevoire irevoire self-assigned this May 24, 2023
@irevoire irevoire mentioned this issue May 24, 2023
Merged
meili-bors bot added a commit that referenced this issue May 24, 2023
@meili-bors @irevoire
Merge #3775
087866d 
3775: Last error code changes on the new get/delete documents routes r=dureuill a=irevoire

# Pull Request

## Related issue
Fixes #3774

## What does this PR do?
Following the specification: meilisearch/specifications#236

1. Get rid of the `invalid_document_delete_filter` and always use the `invalid_document_filter`
2. Introduce a new `missing_document_filter` instead of returning `invalid_document_delete_filter` (that’s consistent with all the other routes that have a mandatory parameter)
3. Always return the `original_filter` in the details (potentially set to `null`) instead of hiding it if it wasn’t used


Co-authored-by: Tamo <tamo@meilisearch.com>
@irevoire irevoire mentioned this issue May 24, 2023
Closed
@irevoire irevoire linked a pull request May 24, 2023 that will close this issue
Last error code changes on the new get/delete documents routes #3775
Merged
@guimachiavelli guimachiavelli mentioned this issue May 25, 2023
Merged
@curquiza
Copy link
Member

Closed by #3775 and released into v1.2.0-rc.2

@meili-bot meili-bot added the v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05 label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@irevoire irevoire

Labels
error handler Issues related to the returned errors in Meilisearch impacts docs This issue involves changes in the Meilisearch's documentation impacts integrations This issue involves changes in the Meilisearch's integrations v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Last error code changes on the new get/delete documents routes meilisearch/meilisearch
3 participants
@irevoire @curquiza @meili-bot