Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last error code changes on the new get/delete documents routes #3775

Merged
merged 3 commits into from May 24, 2023
Merged

Last error code changes on the new get/delete documents routes #3775

merged 3 commits into from May 24, 2023

Conversation

irevoire
Copy link
Member

Pull Request

Related issue

Fixes #3774

What does this PR do?

Following the specification: meilisearch/specifications#236

  1. Get rid of the invalid_document_delete_filter and always use the invalid_document_filter
  2. Introduce a new missing_document_filter instead of returning invalid_document_delete_filter (that’s consistent with all the other routes that have a mandatory parameter)
  3. Always return the original_filter in the details (potentially set to null) instead of hiding it if it wasn’t used

@irevoire irevoire added the error handler Issues related to the returned errors in Meilisearch label May 24, 2023
@irevoire irevoire added this to the v1.2.0 milestone May 24, 2023
@irevoire irevoire requested a review from dureuill May 24, 2023 09:58
dureuill
dureuill approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦝

bors merge

@irevoire irevoire linked an issue May 24, 2023 that may be closed by this pull request
Last error code changes on the new get/delete documents routes #3774
Closed
@meili-bors
Copy link
Contributor

meili-bors bot commented May 24, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 087866d into release-v1.2.0 May 24, 2023
9 checks passed
@meili-bors meili-bors bot deleted the get-delete-documents branch May 24, 2023 10:40
@curquiza curquiza mentioned this pull request May 25, 2023
Closed
@meili-bot meili-bot added the v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05 label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dureuill dureuill dureuill approved these changes

Assignees
No one assigned
Labels
error handler Issues related to the returned errors in Meilisearch v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Last error code changes on the new get/delete documents routes
3 participants
@irevoire @dureuill @meili-bot