Remove email address from the message at the launch #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdi05
approved these changes
Nov 16, 2021
ferdi05
approved these changes
Nov 16, 2021
|
@curquiza I approved the changes, but it looks like there was an issue... |
bors bot
added a commit
that referenced
this pull request
Dec 7, 2021
1976: Fix download-latest.sh r=curquiza a=Mcdostone # Pull Request ## What does this PR do? Fixes #1975 The script was broken because `grep` matches the word **draft** in the changelog of [v0.25.0rc0](https://github.com/meilisearch/MeiliSearch/releases/tag/v0.25.0rc0) > Misc > Remove email address from the launch message (#1896) `@curquiza` > Remove release drafter workflow (#1882) `@curquiza`⚠️ 👀 ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to MeiliSearch! > Your product is awesome! 1977: Fix Dockerfile r=MarinPostma a=curquiza Remove this error <img width="830" alt="Capture d’écran 2021-12-07 à 17 00 46" src="https://user-images.githubusercontent.com/20380692/145063294-51ae2c50-2468-47e9-a891-542d824cad8e.png"> Co-authored-by: Yann Prono <yann.prono@nist.gov> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest removing this email address from the message at the launch since it can encourage people to think this is an email address for support. Is it something we want @meilisearch/devrel-team since we mostly redirect them to the forum or the slack?