Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download-latest.sh #1976

Merged
merged 2 commits into from
Dec 7, 2021
Merged

Fix download-latest.sh #1976

merged 2 commits into from
Dec 7, 2021

Conversation

Mcdostone
Copy link

Pull Request

What does this PR do?

Fixes #1975

The script was broken because grep matches the word draft in the changelog of v0.25.0rc0

Misc
Remove email address from the launch message (#1896) @curquiza
Remove release drafter workflow (#1882) @curquiza ⚠️👀

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to MeiliSearch!

Your product is awesome!

@curquiza curquiza changed the base branch from main to release-v0.25.0 December 7, 2021 16:24
@curquiza curquiza added this to the v0.25.0 milestone Dec 7, 2021
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof! Nice catch! Thanks a lot!!!

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 7, 2021

Build succeeded:

@bors bors bot merged commit 8096b56 into meilisearch:release-v0.25.0 Dec 7, 2021
bors bot added a commit that referenced this pull request Dec 7, 2021
1978: Fix of `release-v0.25.0` branch into `main` r=curquiza a=curquiza

The fixes in #1976 should be on main to be taken into account by 
```
curl -L https://install.meilisearch.com | sh
```

Co-authored-by: Yann Prono <yann.prono@nist.gov>
Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
@curquiza curquiza added the v0.25.0 PRs/issues solved in v0.25.0 label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v0.25.0 PRs/issues solved in v0.25.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to get the latest stable version of MeiliSearch.
2 participants