Support boolean for the no-analytics flag #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1978: Fix of `release-v0.25.0` branch into `main` r=curquiza a=curquiza The fixes in #1976 should be on main to be taken into account by ``` curl -L https://install.meilisearch.com | sh ``` Co-authored-by: Yann Prono <yann.prono@nist.gov> Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
|
@guimachiavelli, I remembered we talked about this problem some weeks ago, it will be fixed in v0.25.0. |
MarinPostma
approved these changes
Dec 8, 2021
|
@curquiza Even by using the environment variable |
|
Yes, I also tested with it, I get an error message when trying with |
|
Thank you, now we can... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the
no-analyticsflag that was ignoring the value passed to it, therefore ano-analytics falsewas just understood as ano-analyticsand was effectively disabling the analytics instead of enabling them. I found a closed issue about this exact behavior on the structopt repository and applied it here.I don't think we should update the documentation as it must have worked like this from the start of this project. I tested it on my machine and it is working great now. Thank you @nicolasvienot for this issue report.
Fixes #1983.