Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CLI changes for clippy #3464

Merged
merged 1 commit into from Apr 26, 2023
Merged

Remove CLI changes for clippy #3464

merged 1 commit into from Apr 26, 2023

Conversation

dureuill
Copy link
Contributor

@dureuill dureuill commented Feb 7, 2023

Pull Request

Related issue

Reverts #3434, which was linked to rust-lang/rust-clippy#10087, as putting the lint in the pedantic group is being uplifted to Rust 1.67.1 (my thanks to everyone involved in this work 馃帀).

Motivation

  • Using "standard issue" clippy in the CI spares our contributors and us from knowing/remembering to add the lint when running clippy locally
  • In particular, spares us from configuring tools like rust-analyzer to take the lint into account.
  • Should this lint come back in another form in the future, we won't blindly ignore it, and we will be able to reassess it, which will be good wrt writing idiomatic Rust. By the time this occurs, lints might be configurable through clippy.toml too, which would make disabling one globally much more convenient if needs be.

Note

We should wait for the release of Rust 1.67.1 and its propagation to our CI before merging this. The PR won't pass CI before this.

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Uffizzi Preview Environment deployment-14518

鈽侊笍 https://app.uffizzi.com/github.com/meilisearch/meilisearch/pull/3464

馃搫 View Application Logs etc.

The meilisearch preview environment contains a web terminal from where you can run the
meilisearch command. You should be able to access this instance of meilisearch running in
the preview from the link Meilisearch Endpoint link given below.

Web Terminal Endpoint :
Meilisearch Endpoint : /meilisearch

@curquiza
Copy link
Member

curquiza commented Feb 7, 2023

Should be merged after #3461

@dureuill
Copy link
Contributor Author

dureuill commented Feb 7, 2023

Should be merged after the release of Rust 1.67.1, so not now :-)

@curquiza
Copy link
Member

Just discussed with @dureuill -> needs to be rebased

@dureuill
Copy link
Contributor Author

Rebased :-)

@curquiza curquiza added this to the v1.2.0 milestone Apr 26, 2023
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@curquiza curquiza added the maintenance Issue about maintenance (CI, tests, refacto...) label Apr 26, 2023
@bors
Copy link
Contributor

bors bot commented Apr 26, 2023

@bors bors bot merged commit 3ae5872 into main Apr 26, 2023
9 checks passed
@bors bors bot deleted the reset_clippy_to_factory branch April 26, 2023 18:16
@meili-bot meili-bot added the v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05 label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Issue about maintenance (CI, tests, refacto...) v1.2.0 PRs/issues solved in v1.2.0 released on 2023-06-05
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants