Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.67.1 #107743

Merged
merged 5 commits into from
Feb 7, 2023
Merged

Release 1.67.1 #107743

merged 5 commits into from
Feb 7, 2023

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Feb 6, 2023 •
edited
Loading

r? @Mark-Simulacrum

@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Feb 6, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@cuviper
Copy link
Member Author

cuviper commented Feb 7, 2023

@bors r=Mark-Simulacrum rollup=never p=1

@bors
Copy link
Contributor

bors commented Feb 7, 2023

📌 Commit 30e7b05 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2023
This was referenced Feb 7, 2023
Merged
Closed
@bors
Copy link
Contributor

bors commented Feb 7, 2023

⌛ Testing commit 30e7b05 with merge 6f4bb37f6f6c93aa79cd9075fe93de15de995383...

@bors
Copy link
Contributor

bors commented Feb 7, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 7, 2023
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 7, 2023
@cuviper
Copy link
Member Author

cuviper commented Feb 7, 2023

I added #107574 for the macos-12-xl "spending limit" problem.

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Feb 7, 2023

📌 Commit 2242436 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2023
@bors
Copy link
Contributor

bors commented Feb 7, 2023

⌛ Testing commit 2242436 with merge d5a82bb...

@dureuill dureuill mentioned this pull request Feb 7, 2023
Merged
@bors
Copy link
Contributor

bors commented Feb 7, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing d5a82bb to stable...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 7, 2023
@bors bors merged commit d5a82bb into rust-lang:stable Feb 7, 2023
@rustbot rustbot added this to the 1.67.1 milestone Feb 7, 2023
@bors bors mentioned this pull request Feb 7, 2023
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cuviper cuviper mentioned this pull request Feb 8, 2023
Merged
argerus added a commit to boschglobal/kuksa.val that referenced this pull request Feb 11, 2023
@argerus
Fix #uninlined_format_args clippy lint
b6134ca 
This lint was promoted from "pedantic" in Rust 1.67.0.
It was subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args
argerus added a commit to boschglobal/kuksa.val that referenced this pull request Feb 11, 2023
@argerus
Fix clippy::uninlined_format_args lint
3db5292 
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args

This lint was promoted from "pedantic" in Rust 1.67.0.  It was
subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
@argerus argerus mentioned this pull request Feb 11, 2023
Merged
SebastianSchildt pushed a commit to eclipse/kuksa.val that referenced this pull request Feb 13, 2023
@argerus @SebastianSchildt
Fix clippy::uninlined_format_args lint
208dfb1 
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args

This lint was promoted from "pedantic" in Rust 1.67.0.  It was
subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
lukasmittag pushed a commit to boschglobal/kuksa.val that referenced this pull request Mar 9, 2023
@argerus @lukasmittag
Fix clippy::uninlined_format_args lint
733fa2c 
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args

This lint was promoted from "pedantic" in Rust 1.67.0.  It was
subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
bors bot added a commit to meilisearch/meilisearch that referenced this pull request Apr 26, 2023
@bors @dureuill
Merge #3464
3ae5872 
3464: Remove CLI changes for clippy r=curquiza a=dureuill

# Pull Request

## Related issue

Reverts #3434, which was linked to rust-lang/rust-clippy#10087, as putting the lint in the pedantic group [is being uplifted to Rust 1.67.1](rust-lang/rust#107743 (comment)) (my thanks to everyone involved in this work 🎉).

## Motivation

- Using "standard issue" clippy in the CI spares our contributors and us from knowing/remembering to add the lint when running clippy locally
- In particular, spares us from configuring tools like rust-analyzer to take the lint into account.
- Should this lint come back in another form in the future, we won't blindly ignore it, and we will be able to reassess it, which will be good wrt writing idiomatic Rust. By the time this occurs, lints might be configurable through `clippy.toml` too, which would make disabling one globally much more convenient if needs be.

## Note

We should wait for the release of Rust 1.67.1 and its propagation to our CI before merging this. The PR won't pass CI before this.


Co-authored-by: Louis Dureuil <louis@meilisearch.com>
@cuviper cuviper deleted the stable-1.67.1 branch May 21, 2023 03:49
javiergold112 pushed a commit to javiergold112/symmetrical-invention that referenced this pull request Jan 29, 2024
@deliteser112
Fix clippy::uninlined_format_args lint
8186c8e 
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args

This lint was promoted from "pedantic" in Rust 1.67.0.  It was
subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
argerus added a commit to eclipse-kuksa/kuksa-databroker that referenced this pull request Mar 19, 2024
@argerus @SebastianSchildt
Fix clippy::uninlined_format_args lint
d9f3d06 
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args

This lint was promoted from "pedantic" in Rust 1.67.0.  It was
subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
argerus added a commit to eclipse-kuksa/kuksa-databroker that referenced this pull request Mar 19, 2024
@argerus @SebastianSchildt
Fix clippy::uninlined_format_args lint
db8a5af 
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args

This lint was promoted from "pedantic" in Rust 1.67.0.  It was
subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
argerus added a commit to eclipse-kuksa/kuksa-databroker that referenced this pull request Mar 20, 2024
@argerus @SebastianSchildt
Fix clippy::uninlined_format_args lint
6b7cffc 
https://rust-lang.github.io/rust-clippy/master/#uninlined_format_args

This lint was promoted from "pedantic" in Rust 1.67.0.  It was
subsequently [demoted to "pedantic"
again](rust-lang/rust#107743) in 1.67.1, so one
solution would be to just use another version for now.

It does however seem likely that it will be reintroduced at some point,
so applying the fix.

rust-lang/rust-clippy#10265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.1
Development

Successfully merging this pull request may close these issues.
8 participants
@cuviper @rustbot @bors @rust-log-analyzer @Mark-Simulacrum @bjorn3 @compiler-errors @Manishearth