Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide embedders #4318

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Hide embedders #4318

merged 2 commits into from
Jan 15, 2024

Conversation

dureuill
Copy link
Contributor

@dureuill dureuill commented Jan 11, 2024 •
edited
Loading

Hides embedders when it is an empty dictionary.

Manual tests:

  • getting settings with empty embedders: not displayed
  • getting settings with non-empty embedders: displayed like before
  • dump with empty embedders: can be imported
  • dump with non-empty embedders: can be imported

@dureuill dureuill added this to the v1.6.0 milestone Jan 11, 2024
ManyTheFish
ManyTheFish approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@ManyTheFish ManyTheFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@curquiza curquiza linked an issue Jan 15, 2024 that may be closed by this pull request
[v1.6.0.rc-8] embedders key is present even when the vectorSearch is not enabled. #4323
Closed
@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jan 15, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit a6fa0b9 into release-v1.6.0 Jan 15, 2024
10 checks passed
@meili-bors meili-bors bot deleted the hide_embedders branch January 15, 2024 10:38
@dureuill dureuill mentioned this pull request Jan 15, 2024
Closed
@meili-bot meili-bot added the v1.6.0 PRs/issues solved in v1.6.0 released on 2024-01-15 label Jan 16, 2024
@mdubus mdubus mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManyTheFish ManyTheFish ManyTheFish approved these changes

Assignees
No one assigned
Labels
v1.6.0 PRs/issues solved in v1.6.0 released on 2024-01-15
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

[v1.6.0.rc-8] embedders key is present even when the vectorSearch is not enabled.
3 participants
@dureuill @ManyTheFish @meili-bot