Implements the search cutoff #4466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irevoire
added
the
performance
irevoire
added
the
search relevancy
irevoire
force-pushed
the
search-cutoff
branch
2 times, most recently
from
8195141
to
d06b124
Compare
dureuill
requested changes
Mar 19, 2024
milli/src/score_details.rs
Outdated
| @@ -256,6 +261,13 @@ impl ScoreDetails { | |||
| details_map.insert(vector, details); | |||
| order += 1; | |||
| } | |||
| ScoreDetails::Skipped => { | |||
| details_map.insert( | |||
There was a problem hiding this comment.
This will need updating in the scoreDetails spec
dureuill
reviewed
Mar 19, 2024
Co-authored-by: Louis Dureuil <louis@meilisearch.com>
handles the niche case 🐩 in the hybrid search where: 1. a sort ranking rule is the first rule. 2. the keyword search is skipped at the first rule. 3. the semantic search is not skipped at the first rule. Previously, we would have the skipped search winning, whereas we want the non skipped one winning.
dureuill
approved these changes
Mar 19, 2024
|
Merge conflict. |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #4488
What does this PR do?
Skipranking details for the ranking rules that were skipped