Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements the search cutoff #4466

Merged
merged 16 commits into from Mar 20, 2024
Merged

Implements the search cutoff #4466

merged 16 commits into from Mar 20, 2024

Commits on Mar 19, 2024

  1. implements a first version of the cutoff without settings

    @irevoire
    irevoire committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    4a46773 View commit details
    Browse the repository at this point in the history

  2. add a settings for the search cutoff

    @irevoire
    irevoire committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    d1db495 View commit details
    Browse the repository at this point in the history

  3. fix the settings tests

    @irevoire
    irevoire committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    b72495e View commit details
    Browse the repository at this point in the history

  4. fix the search cutoff and add a test

    @irevoire
    irevoire committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    b8cda6c View commit details
    Browse the repository at this point in the history

  5. reduce the size of an integration test

    @irevoire
    irevoire committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ad9192f View commit details
    Browse the repository at this point in the history

  6. stop returning the degraded boolean when a search was cutoff

    @irevoire
    irevoire committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    038c26c View commit details
    Browse the repository at this point in the history

  7. rename the search_cutoff parameter to search_cutoff_ms

    @irevoire
    irevoire committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    6a0c399 View commit details
    Browse the repository at this point in the history

  8. adds the degraded searches to the prometheus dashboard

    @irevoire
    irevoire committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    7bd881b View commit details
    Browse the repository at this point in the history

  9. add an error code test on the setting

    @irevoire
    irevoire committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    4369e9e View commit details
    Browse the repository at this point in the history

  10. Update milli/src/search/mod.rs 

    Co-authored-by: Louis Dureuil <louis@meilisearch.com>
    @irevoire @dureuill
    irevoire and dureuill committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    bfec946 View commit details
    Browse the repository at this point in the history

  11. fix the facet search

    @irevoire
    irevoire committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    0ae3964 View commit details
    Browse the repository at this point in the history

  12. forward the degraded parameter to the hybrid search

    @irevoire
    irevoire committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    7b9e0d2 View commit details
    Browse the repository at this point in the history

  13. return the order in the score details

    @irevoire
    irevoire committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    d8fe4fe View commit details
    Browse the repository at this point in the history

  14. A score of 0.0 is now lesser than a sort result 

    handles the niche case 🐩 in the hybrid search where:
1. a sort ranking rule is the first rule.
2. the keyword search is skipped at the first rule.
3. the semantic search is not skipped at the first rule.

Previously, we would have the skipped search winning, whereas we want the non skipped one winning.
    @dureuill
    dureuill committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    098ab59 View commit details
    Browse the repository at this point in the history

  15. query the detailed score detail in the test

    @irevoire
    irevoire committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    2c3af8e View commit details
    Browse the repository at this point in the history

  16. snapshot the scores side by side with the score details

    @irevoire
    irevoire committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    6079141 View commit details
    Browse the repository at this point in the history