Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Improve error message when sorting without the sort criterion #375

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Improve error message when sorting without the sort criterion #375

merged 2 commits into from
Sep 28, 2021

Conversation

vishnugt
Copy link
Contributor

@vishnugt vishnugt commented Sep 28, 2021 •
edited by Kerollmops

Fixes #365.

@irevoire
Copy link
Member

Good works!
@Kerollmops I think we can merge 👍

Kerollmops
Kerollmops suggested changes Sep 28, 2021
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart fro this little thing, I am ok to merge :)
Thank you!

milli/src/error.rs Outdated Show resolved Hide resolved
@vishnugt @Kerollmops
Change "settings" to "setting"
785c137 
Co-authored-by: Clément Renault <renault.cle@gmail.com>
@vishnugt
Copy link
Contributor Author

Updated it to "setting" @Kerollmops

Kerollmops
Kerollmops approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vishnugt, merging!

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 28, 2021

Build succeeded:

@bors bors bot merged commit adddf3f into meilisearch:main Sep 28, 2021
@curquiza curquiza changed the title Fixes #365 Improve error message when sorting without the sort criterion Sep 28, 2021
@ManyTheFish ManyTheFish mentioned this pull request May 15, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message when sorting without the sort criterion
3 participants
@vishnugt @irevoire @Kerollmops