Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Integrate charabia #540

Merged
merged 4 commits into from
Jun 2, 2022
Merged

Integrate charabia #540

merged 4 commits into from
Jun 2, 2022

Conversation

ManyTheFish
Copy link
Member

@ManyTheFish ManyTheFish commented Jun 2, 2022 •
edited
Loading

@ManyTheFish ManyTheFish added DB breaking The related changes break the DB API breaking The related changes break the milli API labels Jun 2, 2022
@ManyTheFish ManyTheFish marked this pull request as ready for review June 2, 2022 14:57
Kerollmops
Kerollmops previously approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est validax!
bors merge

bors bot added a commit that referenced this pull request Jun 2, 2022
@bors @ManyTheFish
Merge #540
06f6e1e 
540: Integrate charabia r=Kerollmops a=ManyTheFish

related to meilisearch/meilisearch#2375
related to meilisearch/meilisearch#2144
related to meilisearch/meilisearch#2417

Co-authored-by: ManyTheFish <many@meilisearch.com>
@bors
Copy link
Contributor

bors bot commented Jun 2, 2022

Build failed:

Kerollmops
Kerollmops approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 2, 2022

Build succeeded:

@bors bors bot merged commit dd18653 into main Jun 2, 2022
@bors bors bot deleted the integrate-charabia branch June 2, 2022 15:53
@curquiza curquiza mentioned this pull request Jun 2, 2022
Merged
bors bot added a commit that referenced this pull request Jun 2, 2022
@bors @curquiza
Merge #541
05ae6db 
541: Update version for next release (v0.29.0) r=ManyTheFish a=curquiza

Need to update the version since #540 was merged and breaking

Co-authored-by: Clémentine Urquizar <clementine@meilisearch.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

@irevoire irevoire Awaiting requested review from irevoire

Assignees
No one assigned
Labels
API breaking The related changes break the milli API DB breaking The related changes break the DB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ManyTheFish @Kerollmops