Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hebrew language support #2417

Closed
curquiza opened this issue May 23, 2022 · 0 comments · Fixed by #2468
Closed

Hebrew language support #2417

curquiza opened this issue May 23, 2022 · 0 comments · Fixed by #2468
Labels
enhancement New feature or improvement impacts docs This issue involves changes in the Meilisearch's documentation tokenizer Related to the tokenizer repo: https://github.com/meilisearch/tokenizer/ v0.28.0 PRs/issues solved in v0.28.0
Milestone
v0.28.0

Comments

@curquiza
Copy link
Member

curquiza commented May 23, 2022 •
edited
Loading

Just added by an external contributor: the support of the Hebrew language will be available in the new tokenizer version, Charabia 🎉

Like for Chinese and Japanese, a normalizer and a segmenter have been added to Charabia, making Meilisearch tokenizer Hebrew as expected (by the Hebrew community maintaining the normalizer and the segmenter).

If #2375 is closed, this issue is closed as well.

@meilisearch/docs-team
@curquiza curquiza added enhancement New feature or improvement tokenizer Related to the tokenizer repo: https://github.com/meilisearch/tokenizer/ impacts docs This issue involves changes in the Meilisearch's documentation labels May 23, 2022
@curquiza curquiza added this to the v0.28.0 milestone May 23, 2022
@curquiza curquiza changed the title Hebrew support Hebrew language support May 23, 2022
@curquiza curquiza mentioned this issue May 23, 2022
Closed
6 tasks
@ManyTheFish ManyTheFish mentioned this issue Jun 2, 2022
Merged
bors bot added a commit to meilisearch/milli that referenced this issue Jun 2, 2022
@bors @ManyTheFish
Merge #540
06f6e1e 
540: Integrate charabia r=Kerollmops a=ManyTheFish

related to meilisearch/meilisearch#2375
related to meilisearch/meilisearch#2144
related to meilisearch/meilisearch#2417

Co-authored-by: ManyTheFish <many@meilisearch.com>
bors bot added a commit to meilisearch/milli that referenced this issue Jun 2, 2022
@bors @ManyTheFish
Merge #540
dd18653 
540: Integrate charabia r=Kerollmops a=ManyTheFish

related to meilisearch/meilisearch#2375
related to meilisearch/meilisearch#2144
related to meilisearch/meilisearch#2417

Co-authored-by: ManyTheFish <many@meilisearch.com>
@ManyTheFish ManyTheFish mentioned this issue Jun 7, 2022
Merged
4 tasks
bors bot added a commit that referenced this issue Jun 7, 2022
@bors @ManyTheFish
Merge #2468
4006e73 
2468: Update milli 0.29 r=ManyTheFish a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417

Co-authored-by: ManyTheFish <many@meilisearch.com>
bors bot added a commit that referenced this issue Jun 7, 2022
@bors @ManyTheFish
Merge #2468
d8cc786 
2468: Update milli 0.29 r=curquiza a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417

Co-authored-by: ManyTheFish <many@meilisearch.com>
@guimachiavelli guimachiavelli mentioned this issue Jun 7, 2022
Closed
bors bot added a commit that referenced this issue Jun 7, 2022
@bors @ManyTheFish
Merge #2468
0383f5a 
2468: Update milli 0.29 r=ManyTheFish a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417
fixes #2407

Co-authored-by: ManyTheFish <many@meilisearch.com>
bors bot added a commit that referenced this issue Jun 7, 2022
@bors @ManyTheFish
Merge #2468
d52726d 
2468: Update milli 0.29 r=ManyTheFish a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417
fixes #2407

Co-authored-by: ManyTheFish <many@meilisearch.com>
bors bot added a commit that referenced this issue Jun 7, 2022
@bors @ManyTheFish
Merge #2468
6a21b9d 
2468: Update milli 0.29 r=curquiza a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417
fixes #2407

Co-authored-by: ManyTheFish <many@meilisearch.com>
bors bot added a commit that referenced this issue Jun 8, 2022
@bors @ManyTheFish
Merge #2468
f6200ca 
2468: Update milli 0.29 r=irevoire a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417
fixes #2407

Co-authored-by: ManyTheFish <many@meilisearch.com>
bors bot added a commit that referenced this issue Jun 8, 2022
@bors @ManyTheFish
Merge #2468
597500f 
2468: Update milli 0.29 r=curquiza a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417
fixes #2407

Co-authored-by: ManyTheFish <many@meilisearch.com>
bors bot added a commit that referenced this issue Jun 8, 2022
@bors @ManyTheFish
Merge #2468
2f6c054 
2468: Update milli 0.29 r=ManyTheFish a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417
fixes #2407

Co-authored-by: ManyTheFish <many@meilisearch.com>
bors bot added a commit that referenced this issue Jun 8, 2022
@bors @ManyTheFish
Merge #2468
8224d06 
2468: Update milli 0.29 r=ManyTheFish a=ManyTheFish

- [x] Update milli to 0.29
- [x] Integrate charabia
- [x] Set disabled_words to default when Index::exact_words returns None
- [x] Fix ranking rules integration test

fixes #2375
fixes #2144
fixes #2417
fixes #2407

Co-authored-by: ManyTheFish <many@meilisearch.com>
@bors bors bot closed this as completed in #2468 Jun 8, 2022
@bors bors bot closed this as completed in 6171f17 Jun 8, 2022
@curquiza curquiza added the v0.28.0 PRs/issues solved in v0.28.0 label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or improvement impacts docs This issue involves changes in the Meilisearch's documentation tokenizer Related to the tokenizer repo: https://github.com/meilisearch/tokenizer/ v0.28.0 PRs/issues solved in v0.28.0
Projects
None yet
Milestone
v0.28.0
Development

Successfully merging a pull request may close this issue.

Update milli 0.29 meilisearch/meilisearch
1 participant
@curquiza