This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loiclec
previously approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, thank you :)
I was a bit worried about some implementation details when crossing the line of 180deg longitude and about some validation logic, but it looks like everything is handled properly 😄
@gmourier sorry, we took time to prioritize the review of your PR. Could you rebase it please? |
2 tasks
gmourier
commented
Nov 23, 2022
gmourier
commented
Nov 23, 2022
bors try |
tryBuild failed: |
Closed in favor of meilisearch/meilisearch#3405 |
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Feb 6, 2023
3405: Implement geo bounding box r=curquiza a=curquiza Following meilisearch/milli#672 (work from `@gmourier)` Fixes #2761 Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> Co-authored-by: Louis Dureuil <louis@meilisearch.com> Co-authored-by: Tamo <tamo@meilisearch.com>
bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Feb 7, 2023
3405: Implement geo bounding box r=irevoire a=curquiza Following meilisearch/milli#672 (work from `@gmourier)` Fixes #2761 Co-authored-by: Guillaume Mourier <guillaume@meilisearch.com> Co-authored-by: Louis Dureuil <louis@meilisearch.com> Co-authored-by: Tamo <tamo@meilisearch.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #2761
What does this PR do?
_geoBoundingBox((lat, lng), (lat, lng))
filterPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!