Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Replace deprecated gh actions #711

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

pnhatminh
Copy link

Pull Request

Related issue

Fixes #678

What does this PR do?

  • Replace deprecated github action command with newly defined command.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!

Thanks for your PR @pnhatminh

Sorry I realized I read your commit too quickly commit

You should redirect to GITHUB_OUTPUT, cf the article I added in the issue 😊

@curquiza curquiza added the maintenance Issue about maintenance (CI, tests, refacto...) label Nov 28, 2022
@pnhatminh
Copy link
Author

At the first glance, I thought that I could define the env variable as one desired. So it should be $GITHUB_OUTPUT for every env variables that I would use in the following up command, am I right?

@pnhatminh
Copy link
Author

@curquiza I added a sample code here for clarification

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pnhatminh

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 29, 2022

@bors bors bot merged commit de22116 into meilisearch:main Nov 29, 2022
@curquiza curquiza added the no breaking The related changes are not breaking (DB nor API) label Dec 1, 2022
@curquiza curquiza mentioned this pull request Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Issue about maintenance (CI, tests, refacto...) no breaking The related changes are not breaking (DB nor API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output in GitHub actions
3 participants