Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Replace deprecated set-output in GitHub actions #678

Closed
curquiza opened this issue Oct 31, 2022 · 7 comments · Fixed by #711
Closed

Replace deprecated set-output in GitHub actions #678

curquiza opened this issue Oct 31, 2022 · 7 comments · Fixed by #711
Labels
good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...)

Comments

@curquiza
Copy link
Member

curquiza commented Oct 31, 2022

In our GitHub actions, we are using set-output command which is deprecated and will be removed.

Capture d’écran 2022-10-31 à 18 57 38

See this link for example

We need to replace with environment variables, following this GitHub article: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

🔥 Should be done by the end of May 2023 🔥

@curquiza curquiza added good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...) hacktoberfest labels Oct 31, 2022
@SO-HYBE
Copy link

SO-HYBE commented Oct 31, 2022

I can help, assign to me please

@curquiza
Copy link
Member Author

Hello @SO-HYBE

Thanks for your interest in this project 🔥 You are definitely more than welcome to open a PR for this!

For your information, we prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages the volunteer contributors from opening a PR to fix this issue.
We will accept and merge the first PR that fixes correctly and well implements the issue following our contributing guidelines.

We are looking forward to reviewing your PR 😊

@SO-HYBE
Copy link

SO-HYBE commented Oct 31, 2022

Ok I got your point. Let's do it

@azzamsa
Copy link
Contributor

azzamsa commented Nov 26, 2022

@SO-HYBE Hi. I don't see any opened PR from you. Are you still with this? Or may I take over?

@pnhatminh
Copy link

@curquiza Hi there.
I have made the change to the workflows according to the presented documentation. You could find my change here
However, I am not able to trigger any workflow for testing, as it keeps Waiting for a runner to pick up this job...
Do you have any suggestion on the testing for this issue?

@curquiza
Copy link
Member Author

curquiza commented Nov 28, 2022

Hello @pnhatminh can you open a PR so that I can review and merge it? 😊 The changes you made seem ok

@pnhatminh
Copy link

@curquiza please approve my pr and merge it

@bors bors bot closed this as completed in de22116 Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers maintenance Issue about maintenance (CI, tests, refacto...)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants