Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issues raised by goodpractice::gp() #17

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Resolve issues raised by goodpractice::gp() #17

merged 2 commits into from
Jun 18, 2024

Conversation

meixichen
Copy link
Owner

  • Replace nrow(), ncol() and length() by seq_along().
  • Replace sapply() by vapply() with FUN.VALUE specified.
  • Add link in DESCRIPTION.
  • Remove trailing semicolons.
  • Import functions in a package rather than importing the whole package

@meixichen meixichen merged commit 6f4470c into joss Jun 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant