Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config for the gauge dropper to not be able to be used on creative tanks #7100

Closed
EnabledEnzo opened this issue Apr 12, 2021 · 8 comments

Comments

@EnabledEnzo
Copy link

EnabledEnzo commented Apr 12, 2021

I help plan ideas for a mod pack and was wondering if its possible to add a config for the gauge dropper on being able to be used on creative chemical/fluid tanks or not.

we have considered just black listing the item but we came to the conclusion its just too useful to blacklist.

@ShaleTheRock
Copy link

ShaleTheRock commented Apr 12, 2021

In my eyes, this would not make much sense as the creative tank is only obtainable via the creative inventory (unless you added a recipe for it).

  • some random modded MC player

@thiakil
Copy link
Member

thiakil commented Apr 12, 2021

But why don't you want it usable on the creative tank? You can just... use any other tank to get from the creative and use the dropper on that...

@EnabledEnzo
Copy link
Author

That is exactly the goal adding a recipe for one but the problem is once someone gets it they can just empty it and add anything else they wanted and that gas would become infinite.

@thiakil
Copy link
Member

thiakil commented Apr 12, 2021

Er, have you actually tried that? The creative tank's contents should never decrease. It is not possible to empty it.

(if it is possible, that's a bug)

@EnabledEnzo
Copy link
Author

yeah tested before coming here

@pupnewfster
Copy link
Member

pupnewfster commented Apr 12, 2021

It is actually fully intended to clear the creative tank's/chemical tank's contents, what the gauge dropper doesn't do for creative tanks is decrease their contents when just trying to pickup the contents of the tank. I am not fully against the idea of adding a config option for disabling voiding creative tanks as I can sort of see why a pack dev may want it, though it may be a bit of a headache to implement.

@pupnewfster pupnewfster added this to the 10.1.0 milestone Apr 12, 2021
@pupnewfster
Copy link
Member

We discussed this some and the plan is for 10.1 to try and make it so that it only can be used to dump the contents of creative tanks when the player is in creative.

@djnugets
Copy link

that would work perfectly for what we are trying to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants