Math API Division Optimization #6988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added test coverage for each of the new methods.
pupnewfster
reviewed
Feb 15, 2021
|
This pull request introduces 2 alerts when merging 799fdb4 into d40d607 - view on LGTM.com new alerts:
|
BlueAgent
reviewed
Feb 15, 2021
BlueAgent
reviewed
Feb 15, 2021
-Add test to ensure no dividebyzero errors
…ions to storing the intermediary value
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Added optimizing methods for commonly used division operations.
-Added test coverage for each of the new methods.