Add new FhirContactPoints domain. #253
Conversation
mherman22
changed the title
mherman22
force-pushed
the
ContactPointMap-impl
branch
from
93423e2
to
2ded69e
Compare
| return locationService.getLocationAttributeTypeByUuid(attributeType); | ||
| break; | ||
| case PROVIDER: | ||
| baseAttributeType = providerService.getProviderAttributeTypeByName(attributeType); |
There was a problem hiding this comment.
i guess we need to backport this commit (that introduces the getProviderAttributeTypeByName() method) to the 2.5.x branch curently at 5.13.0-SNAPSHOT branch.
cc: @ibacher
There was a problem hiding this comment.
Hmmm... let's just target this at 2.6+ then. I think that's less confusing.
| import static org.hamcrest.Matchers.equalTo; | ||
| import static org.hamcrest.Matchers.is; | ||
|
|
||
| public class FhirPatientContactPointMapIntegrationTest extends DomainBaseModuleContextSensitiveTest { |
There was a problem hiding this comment.
I think this test needs to be in the api-2.5 (probably api-2.6) submodule or something.
|
@mherman22 Is there no way to get this to work without shifting to 2.0.0 of the FHIR2 module? I would prefer to support older versions. |
I was trying this out. I'm pushing it back to 1.11.0 however the challenge there has to do with the location type translator not being got as a bean i.e NoSuchBeanException |
mherman22
force-pushed
the
ContactPointMap-impl
branch
from
5d7bd68
to
3aa66b2
Compare
mherman22
force-pushed
the
ContactPointMap-impl
branch
from
3aa66b2
to
f778a03
Compare
mherman22
force-pushed
the
ContactPointMap-impl
branch
from
f778a03
to
825acb5
Compare
mherman22
force-pushed
the
ContactPointMap-impl
branch
from
825acb5
to
8bc7331
Compare
|
It looks like we're going to need to make 2.6 the minimum version for the LoaderTest and probably the validator too for this to work. @Ruhanga Do you have an opinion on that? Otherwise, we maybe add something to the Loader to not try to run a domain if a valid version of a loader isn't available. |
Fyi, I have done this locally though it is now not loading the loader for QUEUE so I am still looking for a workaround around that. |
mherman22
force-pushed
the
ContactPointMap-impl
branch
from
6761356
to
a18324e
Compare
@ibacher, @mherman22 concerning the above, upgrading to OpenMRS Core greater than 2.4.0 might require refactoring on the part of the Validator to accommodate new changes + upgraded libraries on Core. This will consequently need some extensive testing of the Validator itself. |
mherman22
force-pushed
the
ContactPointMap-impl
branch
from
f3907bf
to
07f2377
Compare
|
First bit looks like we need to change the calls like: executeChangelog("changelog", null);To: executeChangelog("changelog", (ChangeSetExecutorCallback) null);In ConfigTester... |
No description provided.