Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change openmrs version on locationTypeTranslatorImpl #527

Closed
wants to merge 1 commit into from

Conversation

mherman22
Copy link
Contributor

@mherman22 mherman22 commented Oct 31, 2023

Description of what I changed

This commit changes the versions of openmrs the locationtypetranslatorImpl supports starting with 2.4.1. This i believe will unblock mekomsolutions/openmrs-module-initializer#253.

Issue I worked on

see https://issues.openmrs.org/browse/FM2-

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@mherman22
Copy link
Contributor Author

@ibacher take a look at this and if it makes sense then kindly backport it to 1.11.0.

@mherman22
Copy link
Contributor Author

mherman22 commented Oct 31, 2023

@ibacher take a look at this and if it makes sense then kindly backport it to 1.11.0.

I have actually realized backporting to 1.11.0 doesnt work well with this change so i am gonna have to look for another solution to the predicament at mekomsolutions/openmrs-module-initializer#253

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6b00ddb) 77.79% compared to head (ea26075) 77.81%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #527      +/-   ##
============================================
+ Coverage     77.79%   77.81%   +0.02%     
+ Complexity     2679     2677       -2     
============================================
  Files           239      239              
  Lines          7430     7440      +10     
  Branches        897      897              
============================================
+ Hits           5780     5789       +9     
  Misses         1114     1114              
- Partials        536      537       +1     
Files Coverage Δ
...api/search/SearchQueryBundleProviderR3Wrapper.java 57.89% <100.00%> (ø)
...i/translators/impl/LocationTypeTranslatorImpl.java 80.00% <ø> (ø)
...ers/r3/AllergyIntoleranceFhirResourceProvider.java 91.30% <100.00%> (+0.40%) ⬆️
...r2/providers/r3/ConditionFhirResourceProvider.java 77.27% <100.00%> (+1.08%) ⬆️
...iders/r3/DiagnosticReportFhirResourceProvider.java 91.30% <100.00%> (+0.40%) ⬆️
...r2/providers/r3/EncounterFhirResourceProvider.java 38.98% <100.00%> (+1.05%) ⬆️
.../fhir2/providers/r3/GroupFhirResourceProvider.java 88.24% <100.00%> (+1.57%) ⬆️
...ir2/providers/r3/LocationFhirResourceProvider.java 90.91% <100.00%> (+0.43%) ⬆️
...ers/r3/MedicationDispenseFhirResourceProvider.java 92.59% <100.00%> (ø)
...ders/r3/MedicationRequestFhirResourceProvider.java 80.00% <100.00%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mherman22 mherman22 closed this Nov 21, 2023
@mherman22 mherman22 deleted the locationTransImpl branch November 21, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant