Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(reactjs-jsx-ppx): react/jsx-runtime transform #544

Closed
wants to merge 1 commit into from
Closed

feat(reactjs-jsx-ppx): react/jsx-runtime transform #544

wants to merge 1 commit into from

Conversation

anmonteiro
Copy link
Member

No description provided.

jchavarri
jchavarri approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@jchavarri jchavarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! What would be the release plan? I understand it relies on both the reason-react changes, and the ReactJS package being > 17 right? or 18?

reactjs-jsx-ppx/reactjs_jsx_ppx_v3.ml Show resolved Hide resolved
reactjs-jsx-ppx/reactjs_jsx_ppx_v3.ml Show resolved Hide resolved
reactjs-jsx-ppx/reactjs_jsx_ppx_v3.ml Outdated Show resolved Hide resolved
reactjs-jsx-ppx/reactjs_jsx_ppx_v3.ml Show resolved Hide resolved
reactjs-jsx-ppx/reactjs_jsx_ppx_v3.ml Show resolved Hide resolved
@anmonteiro
Copy link
Member Author

anmonteiro commented May 1, 2023 •
edited

What would be the release plan?

I think we can probably get away with:

  • releasing the ppx to opam as v0.1 (this can be done at the same time as we release from the mel branch.)
  • merging this pr
  • release as v1.0

Then consumers would be able to select which version of the ppx they want in their projects.

@anmonteiro anmonteiro force-pushed the anmonteiro/reactjs-jsx-transform branch from 844fa6c to d197b6c Compare May 1, 2023 03:30
@anmonteiro anmonteiro marked this pull request as ready for review May 1, 2023 05:28
@anmonteiro anmonteiro force-pushed the anmonteiro/reactjs-jsx-transform branch 5 times, most recently from 4e32328 to 15981e4 Compare May 15, 2023 22:13
@anmonteiro anmonteiro force-pushed the anmonteiro/reactjs-jsx-transform branch from 15981e4 to 1aba163 Compare June 1, 2023 03:16
@anmonteiro
Copy link
Member Author

tracking the rest of this in reasonml/reason-react#714

@anmonteiro anmonteiro closed this Jun 1, 2023
@anmonteiro anmonteiro deleted the anmonteiro/reactjs-jsx-transform branch September 12, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchavarri jchavarri jchavarri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anmonteiro @jchavarri