-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: react/jsx-runtime #714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments as if was ready to review, most of them are questions but I would avoid the change of the API under React.string, React.int, React.float, etc.
The rest looks good
src/jsx.re
Outdated
type element; | ||
type ref; | ||
|
||
[@bs.val] external null: element = "null"; | ||
|
||
external float: float => element = "%identity"; | ||
external int: int => element = "%identity"; | ||
external string: string => element = "%identity"; | ||
|
||
external array: array(element) => element = "%identity"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need to include Jsx
in React module, otherwise those functions won't be available under React.*
3145107
to
73ee416
Compare
73ee416
to
fe1b176
Compare
1c35274
to
8a378da
Compare
a35f96b
to
5335334
Compare
Not really sure what these errors are about?
will investigate. |
There seems to be some issue with bindings, when building
|
Ah, makes sense, was missing the ppx 0da7411 |
🚀 ❓ |
…1-release * 'main' of github.com:/reasonml/reason-react: feat: react/jsx-runtime (#714)
CHANGES: * Migrate the reason-react PPX and library to the [new React JSX transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html) (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714)) * Add `suppressHydrationWarning` to supported props (@davesnx in [reasonml/reason-react#721](reasonml/reason-react#721)) * Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732)) * Fix locations for lower and uppercase components so that merlin / editor integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748)) * Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750)) * Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files)) * Make optional props optional properly ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))
CHANGES: * Migrate the reason-react PPX and library to the [new React JSX transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html) (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714)) * Add `suppressHydrationWarning` to supported props (@davesnx in [reasonml/reason-react#721](reasonml/reason-react#721)) * Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732)) * Fix locations for lower and uppercase components so that merlin / editor integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748)) * Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750)) * Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files)) * Make optional props optional properly ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))
CHANGES: * Migrate the reason-react PPX and library to the [new React JSX transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html) (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714)) * Add `suppressHydrationWarning` to supported props (@davesnx in [reasonml/reason-react#721](reasonml/reason-react#721)) * Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732)) * Fix locations for lower and uppercase components so that merlin / editor integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748)) * Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750)) * Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files)) * Make optional props optional properly ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))
CHANGES: * Migrate the reason-react PPX and library to the [new React JSX transform](https://legacy.reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html) (@anmonteiro in [reasonml/reason-react#714](reasonml/reason-react#714)) * Add `suppressHydrationWarning` to supported props (@davesnx in [reasonml/reason-react#721](reasonml/reason-react#721)) * Rename `reactjs-jsx-ppx` to `reason-react-ppx` ([@davesnx in reasonml/reason-react#732](reasonml/reason-react#732)) * Fix locations for lower and uppercase components so that merlin / editor integration can get type defs on hover ([@jchavarri in reasonml/reason-react#748](reasonml/reason-react#748)) * Refine types for `key` attributes ([@anmonteiro in reasonml/reason-react#750](reasonml/reason-react#750)) * Bump React depext to v17-18 reasonml/reason-react#777 ([@jchavarri in reasonml/reason-react#777](https://github.com/reasonml/reason-react/pull/777/files)) * Make optional props optional properly ([@davesnx in reasonml/reason-react#776](reasonml/reason-react@0a98c07))
No description provided.