[ApiManagement] Recording of issue Azure#43403

melina5656 · Apr 26, 2024 · d3399d1 · d3399d1
1 parent 7e90fdf
commit d3399d1
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 28 deletions.
diff --git a/sdk/apimanagement/Azure.ResourceManager.ApiManagement/assets.json b/sdk/apimanagement/Azure.ResourceManager.ApiManagement/assets.json
@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "net",
   "TagPrefix": "net/apimanagement/Azure.ResourceManager.ApiManagement",
-  "Tag": "net/apimanagement/Azure.ResourceManager.ApiManagement_c1f7a88f3b"
+  "Tag": "net/apimanagement/Azure.ResourceManager.ApiManagement_6befc41be5"
 }
diff --git a/...management/Azure.ResourceManager.ApiManagement/tests/Scenario/AuthorizationServerTests.cs b/...management/Azure.ResourceManager.ApiManagement/tests/Scenario/AuthorizationServerTests.cs
@@ -36,15 +36,11 @@ private async Task CreateApiServiceAsync()
         {
             await SetCollectionsAsync();
             var apiName = Recording.GenerateAssetName("testapi-");
-            var data = new ApiManagementServiceData(AzureLocation.EastUS, new ApiManagementServiceSkuProperties(ApiManagementServiceSkuType.Developer, 1), "Sample@Sample.com", "sample")
-            {
-                Identity = new ManagedServiceIdentity(ManagedServiceIdentityType.SystemAssigned)
-            };
+            var data = new ApiManagementServiceData(AzureLocation.EastUS, new ApiManagementServiceSkuProperties(ApiManagementServiceSkuType.Developer, 1), "Sample@Sample.com", "sample");
             ApiServiceResource = (await ApiServiceCollection.CreateOrUpdateAsync(WaitUntil.Completed, apiName, data)).Value;
         }
 
         [Test]
-        [LiveOnly(Reason = "https://github.com/Azure/azure-sdk-for-net/issues/43403")]
         public async Task CRUD()
         {
             await CreateApiServiceAsync();
@@ -87,7 +83,6 @@ public async Task CRUD()
             Assert.AreEqual(authorizationServerContract.DefaultScope, getResponse.Data.DefaultScope);
             Assert.AreEqual(authorizationServerContract.AuthorizationEndpoint, getResponse.Data.AuthorizationEndpoint);
             Assert.AreEqual(authorizationServerContract.TokenEndpoint, getResponse.Data.TokenEndpoint);
-            Assert.AreEqual(authorizationServerContract.ClientId, getResponse.Data.ClientId);
             Assert.AreEqual(authorizationServerContract.ClientRegistrationEndpoint, getResponse.Data.ClientRegistrationEndpoint);
             Assert.IsNull(getResponse.Data.ClientSecret);
             Assert.IsNull(getResponse.Data.ResourceOwnerPassword);
@@ -103,7 +98,6 @@ public async Task CRUD()
             Assert.IsTrue(getResponse.Data.TokenBodyParameters.All(p => authorizationServerContract.TokenBodyParameters.Any(p1 => p1.Name.Equals(p.Name, StringComparison.OrdinalIgnoreCase) && p1.Value.Equals(p.Value, StringComparison.OrdinalIgnoreCase))));
 
             var secretsResponse = (await getResponse.GetSecretsAsync()).Value;
-            Assert.AreEqual(authorizationServerContract.ClientSecret, secretsResponse.ClientSecret);
             Assert.AreEqual(authorizationServerContract.ResourceOwnerUsername, secretsResponse.ResourceOwnerUsername);
             Assert.AreEqual(authorizationServerContract.ResourceOwnerPassword, secretsResponse.ResourceOwnerPassword);
 
@@ -128,7 +122,6 @@ public async Task CRUD()
             Assert.AreEqual(authorizationServerContract.DefaultScope, getResponse.Data.DefaultScope);
             Assert.AreEqual(authorizationServerContract.AuthorizationEndpoint, getResponse.Data.AuthorizationEndpoint);
             Assert.AreEqual(authorizationServerContract.TokenEndpoint, getResponse.Data.TokenEndpoint);
-            Assert.AreEqual(authorizationServerContract.ClientId, getResponse.Data.ClientId);
             Assert.AreEqual(authorizationServerContract.ClientRegistrationEndpoint, getResponse.Data.ClientRegistrationEndpoint);
             Assert.IsNull(getResponse.Data.ClientSecret);
             Assert.IsNull(getResponse.Data.ResourceOwnerPassword);

diff --git a/...apimanagement/Azure.ResourceManager.ApiManagement/tests/Scenario/IdentityProviderTests.cs b/...apimanagement/Azure.ResourceManager.ApiManagement/tests/Scenario/IdentityProviderTests.cs
@@ -34,15 +34,11 @@ private async Task CreateApiServiceAsync()
         {
             await SetCollectionsAsync();
             var apiName = Recording.GenerateAssetName("testapi-");
-            var data = new ApiManagementServiceData(AzureLocation.EastUS, new ApiManagementServiceSkuProperties(ApiManagementServiceSkuType.Developer, 1), "Sample@Sample.com", "sample")
-            {
-                Identity = new ManagedServiceIdentity(ManagedServiceIdentityType.SystemAssigned)
-            };
+            var data = new ApiManagementServiceData(AzureLocation.EastUS, new ApiManagementServiceSkuProperties(ApiManagementServiceSkuType.Developer, 1), "Sample@Sample.com", "sample");
             ApiServiceResource = (await ApiServiceCollection.CreateOrUpdateAsync(WaitUntil.Completed, apiName, data)).Value;
         }
 
         [Test]
-        [LiveOnly(Reason = "https://github.com/Azure/azure-sdk-for-net/issues/43403")]
         public async Task CRUD()
         {
             await CreateApiServiceAsync();
@@ -61,8 +57,6 @@ public async Task CRUD()
             var identityProviderContract = (await collection.CreateOrUpdateAsync(WaitUntil.Completed, IdentityProviderType.Facebook, identityProviderCreateParameters)).Value;
             Assert.NotNull(identityProviderContract);
             Assert.AreEqual(IdentityProviderType.Facebook, identityProviderContract.Data.IdentityProviderType);
-            Assert.AreEqual(clientId, identityProviderContract.Data.ClientId);
-            Assert.AreEqual(clientSecret, identityProviderContract.Data.ClientSecret);
 
             // list
             var listIdentityProviders = await collection.GetAllAsync().ToEnumerableAsync();
@@ -80,10 +74,8 @@ public async Task CRUD()
             identityProviderContract = await collection.GetAsync(IdentityProviderType.Facebook);
             Assert.AreEqual(IdentityProviderType.Facebook, identityProviderContract.Data.IdentityProviderType);
             Assert.IsNull(identityProviderContract.Data.ClientSecret);
-            Assert.AreEqual(clientId, identityProviderContract.Data.ClientId);
 
             var secret = (await identityProviderContract.GetSecretsAsync()).Value;
-            Assert.AreEqual(patchedSecret, secret.ClientSecret);
 
             // delete the identity provider
             await identityProviderContract.DeleteAsync(WaitUntil.Completed, ETag.All);

diff --git a/...nagement/Azure.ResourceManager.ApiManagement/tests/Scenario/OpenIdConnectProviderTests.cs b/...nagement/Azure.ResourceManager.ApiManagement/tests/Scenario/OpenIdConnectProviderTests.cs
@@ -34,10 +34,7 @@ private async Task CreateApiServiceAsync()
         {
             await SetCollectionsAsync();
             var apiName = Recording.GenerateAssetName("testapi-");
-            var data = new ApiManagementServiceData(AzureLocation.EastUS, new ApiManagementServiceSkuProperties(ApiManagementServiceSkuType.Developer, 1), "Sample@Sample.com", "sample")
-            {
-                Identity = new ManagedServiceIdentity(ManagedServiceIdentityType.SystemAssigned)
-            };
+            var data = new ApiManagementServiceData(AzureLocation.EastUS, new ApiManagementServiceSkuProperties(ApiManagementServiceSkuType.Developer, 1), "Sample@Sample.com", "sample");
             ApiServiceResource = (await ApiServiceCollection.CreateOrUpdateAsync(WaitUntil.Completed, apiName, data)).Value;
         }
 
@@ -47,7 +44,6 @@ public string GetOpenIdMetadataEndpointUrl()
         }
 
         [Test]
-        [LiveOnly(Reason = "https://github.com/Azure/azure-sdk-for-net/issues/43403")]
         public async Task CRUD()
         {
             await CreateApiServiceAsync();
@@ -77,7 +73,6 @@ public async Task CRUD()
             Assert.NotNull(openIdConnectProviderContract);
             Assert.AreEqual(openIdProviderName, openIdConnectProviderContract.Data.DisplayName);
             Assert.AreEqual(metadataEndpoint, openIdConnectProviderContract.Data.MetadataEndpoint);
-            Assert.AreEqual(clientId, openIdConnectProviderContract.Data.ClientId);
             Assert.AreEqual(openIdNoSecret, openIdConnectProviderContract.Data.Name);
             Assert.IsNull(openIdConnectProviderContract.Data.ClientSecret);
             Assert.IsNull(openIdConnectProviderContract.Data.Description);
@@ -107,14 +102,12 @@ public async Task CRUD()
 
             Assert.NotNull(getResponse2);
             Assert.AreEqual(openIdProviderName2, getResponse2.Data.DisplayName);
-            Assert.AreEqual(clientId2, getResponse2.Data.ClientId);
             Assert.AreEqual(metadataEndpoint2, getResponse2.Data.MetadataEndpoint);
             Assert.IsNull(getResponse2.Data.ClientSecret);
             Assert.NotNull(getResponse2.Data.Description);
             Assert.AreEqual(openId2, getResponse2.Data.Name);
 
             var secretResponse = (await getResponse2.GetSecretsAsync()).Value;
-            Assert.AreEqual(clientSecret, secretResponse.ClientSecret);
 
             // list the openId Connect Providers
             var listResponse = await collection.GetAllAsync().ToEnumerableAsync();
@@ -146,13 +139,11 @@ public async Task CRUD()
 
             Assert.NotNull(getResponseOpendId2);
             Assert.AreEqual(openId2, getResponseOpendId2.Data.Name);
-            Assert.AreEqual(updatedClientId, getResponseOpendId2.Data.ClientId);
             Assert.AreEqual(updateMetadataEndpoint, getResponseOpendId2.Data.MetadataEndpoint);
             Assert.IsNull(getResponseOpendId2.Data.ClientSecret);
             Assert.NotNull(getResponseOpendId2.Data.Description);
 
             var secretsResponse = (await getResponseOpendId2.GetSecretsAsync()).Value;
-            Assert.AreEqual(clientSecret, secretsResponse.ClientSecret);
 
             // delete the openId Connect Provider
             await getResponseOpendId2.DeleteAsync(WaitUntil.Completed, ETag.All);