Remove console logs from production build

[ghost]

Would it be possible to remove all console.log() calls in the production build? The extension frequently logs errors to the console and as a dev, it's distracting. Most commonly, this part of the code throws an error when "x or y are negative, outside viewport, or there is no text entry node" and range ends up null. For me, mousing over the scrollbar often triggers this. I'm using Chrome 89 though this issue has been present on previous versions as well.

range = document.caretRangeFromPoint(ev.clientX, ev.clientY);
rp = range.startContainer;

Really appreciate the work on this extension :)

[melink14]

I removed info logs awhile back but not error logs.
I think having error logs is important for people reporting bugs though in general.

Maybe there's a way to format the logs so they're easily hidden using dev tools. Could also try to make that particular error less common. It's never really been looked at for years.

[ghost]

That's fair; in Chrome at least I can check "Selected context only" to hide the logs from unrelated contexts like extensions. A fix would also be appreciated but I understand if it's not a high priority. Thanks!

[melink14]

If you right click on the message it looks like you can "Hide messages from rikaicontent.js" which would be easy enough while doing dev work. That being said, I'll keep this open to think about other solutions since I agree that non actionable logs like this are non ideal.

…

On Fri, Mar 12, 2021 at 7:55 AM qkjosh ***@***.***> wrote: That's fair; in Chrome at least I can check "Selected context only" to hide the logs from unrelated contexts like extensions. A fix would also be appreciated but I understand if it's not a high priority. Thanks! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#386 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAI7HZXTIFALCAUYCCRMXUTTDE34VANCNFSM4ZBAFCHA> .

[melink14]

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

• Chrome Web Store
• GitHub release

Your semantic-release bot 📦🚀

[melink14]

I will re-open this issue as I think it's worth thinking about solving this in a general way.