Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Force Google Docs to use HTML mode instead of canvas mode #596

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

melink14
Copy link
Owner

Google Docs new canvas mode hides all text/dom from rikaikun and thus for rikaikun to work Google has provided a workaround.

Fixes #593

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #596 (8b6e9a2) into main (cb97f36) will increase coverage by 2.31%.
The diff coverage is 99.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
+ Coverage   37.50%   39.81%   +2.31%     
==========================================
  Files           3       11       +8     
  Lines        1384     3104    +1720     
  Branches       18       48      +30     
==========================================
+ Hits          519     1236     +717     
- Misses        865     1868    +1003     
Impacted Files Coverage Δ
extension/background.ts 48.27% <93.33%> (ø)
extension/docs-html-fallback.ts 100.00% <100.00%> (ø)
extension/test/background_test.ts 100.00% <100.00%> (ø)
extension/test/docs-html-fallback_test.ts 100.00% <100.00%> (ø)
extension/data.ts 26.28% <0.00%> (ø)
extension/rikaichan.ts 50.00% <0.00%> (ø)
extension/configuration.ts 79.54% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb97f36...8b6e9a2. Read the comment docs.

@melink14 melink14 force-pushed the melink14/issue593/Support-docs-in-canvas-mode branch 2 times, most recently from 0359502 to 5d1db46 Compare July 12, 2021 23:37
@melink14 melink14 force-pushed the melink14/issue366/Multi-layered-HTML-prevents-word-detection branch from 8d2c396 to 6bd752e Compare July 16, 2021 13:02
@melink14 melink14 force-pushed the melink14/issue593/Support-docs-in-canvas-mode branch from 5d1db46 to e786e5c Compare July 16, 2021 13:03
@melink14 melink14 force-pushed the melink14/issue366/Multi-layered-HTML-prevents-word-detection branch from 6bd752e to 1260f33 Compare July 16, 2021 13:07
@melink14 melink14 force-pushed the melink14/issue593/Support-docs-in-canvas-mode branch from e786e5c to dd7cafc Compare July 16, 2021 13:10
@melink14 melink14 force-pushed the melink14/issue366/Multi-layered-HTML-prevents-word-detection branch from 1260f33 to 73d825a Compare July 16, 2021 13:20
Base automatically changed from melink14/issue366/Multi-layered-HTML-prevents-word-detection to main July 16, 2021 13:32
Google Docs new canvas mode hides all text/dom from rikaikun and thus for rikaikun to work Google has provided a workaround.

Fixes #593
@melink14 melink14 force-pushed the melink14/issue593/Support-docs-in-canvas-mode branch from dd7cafc to 8b6e9a2 Compare July 16, 2021 13:37
@melink14 melink14 merged commit 94b60a6 into main Jul 16, 2021
@melink14 melink14 deleted the melink14/issue593/Support-docs-in-canvas-mode branch July 16, 2021 13:46
melink14 pushed a commit that referenced this pull request Jul 17, 2021
## [2.0.0](v1.2.6...v2.0.0) (2021-07-17)

### ⚠ BREAKING CHANGES

* This version includes optional chaining requiring Chrome >=80

### Features

* Force Google Docs to use HTML mode instead of canvas mode ([#596](#596)) ([94b60a6](94b60a6)), closes [#593](#593)
* **detection:** Ignore invisible nodes when extracting text under mouse ([#561](#561)) ([cb97f36](cb97f36)), closes [#159](#159) [#366](#366) [#159](#159)

### Bug Fixes

* **dict:** Update dictionaries to latest versions. ([#581](#581)) ([77189c3](77189c3))
* Skip text processing when range is null ([#598](#598)) ([ae55bff](ae55bff)), closes [#386](#386)

### Code Refactoring

* Migrate from webpack to snowpack for build step ([#583](#583)) ([1bdd3d3](1bdd3d3))
@melink14
Copy link
Owner Author

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support docs in canvas mode
1 participant