Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove fake div if returning early because caretRangeFromPoint is null #1134

Merged
merged 1 commit into from
Jul 17, 2022
Merged

fix: Remove fake div if returning early because caretRangeFromPoint is null #1134

merged 1 commit into from
Jul 17, 2022

Conversation

Stephie
Copy link
Collaborator

@Stephie Stephie commented Jul 17, 2022

Fixes #1114

@Stephie Stephie changed the title fix: Remove fake div if returning early because caretRangeFromPoint is null fix: Remove fake div if returning early because caretRangeFromPoint is null Jul 17, 2022
@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #1134 (04420aa) into main (1b58e6a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1134      +/-   ##
==========================================
+ Coverage   79.08%   79.10%   +0.02%     
==========================================
  Files           7        7              
  Lines        2998     3001       +3     
  Branches      186      186              
==========================================
+ Hits         2371     2374       +3     
  Misses        622      622              
  Partials        5        5
Impacted Files Coverage Δ
extension/rikaicontent.ts 74.78% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b58e6a...04420aa. Read the comment docs.

@mergify mergify bot merged commit e7d40b8 into main Jul 17, 2022
@mergify mergify bot deleted the stephie/early-return-bug branch July 17, 2022 12:49
melink14 pushed a commit that referenced this pull request Jul 18, 2022
@semantic-release-bot
chore(release): 2.4.11
3847140 
## [2.4.11](v2.4.10...v2.4.11) (2022-07-18)

### Bug Fixes

* **dict:** Update dictionaries to latest versions ([#1140](#1140)) ([70de0be](70de0be))
* Remove fake div if returning early because `caretRangeFromPoint` is null ([#1134](#1134)) ([e7d40b8](e7d40b8)), closes [#1114](#1114)
@melink14
Copy link
Owner

🎉 This PR is included in version 2.4.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melink14 melink14 melink14 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page with no text gets affected when rikaikun in enabled
2 participants
@Stephie @melink14