-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page with no text gets affected when rikaikun in enabled #1114
Comments
Thanks @greggman for reporting! This is definitely an bug! cc @all-contributors The most direct cause is this early return which doesn't remove fake div we use when we detect inputs: rikaikun/extension/rikaicontent.ts Lines 1176 to 1178 in cfac104
It probably doesn't come up much since it requires the mouse to be outside the viewport and a range slider which is near the edge of the frame is an easier way to repro than most real situations! More than that though, I think we should limit the types of inputs we try to extract text from. It was originally added when Let's leave this bug for properly cleaning up the added |
@all-contributors please add @greggman for bugs |
I've put up a pull request to add @greggman! 🎉 |
Add @greggman as a contributor for bug. This was requested by melink14 [in this comment](#1114 (comment))
While debugging I found that sometimes the iframe of jsgist is a |
🎉 This issue has been resolved in version 2.4.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Describe the bug
Page with no text gets broken when rikaikun is enabled. Note: This is not a priority or a request for fixing/support. Rather, given that it was easy to reproduce I thought i'd report it as maybe such a simple case is an easy repo for some other harder to repo case.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The slider functions correctly (it's just a styled
<input type="range">
Screenshots
A "0" appears on the left and the slider stop working. This only happens if rikaikun is enabled.
System details (OS, browser version, rikaikun version)
Additional context
Thanks so much for Rikaikun!!!! I've used it for years and it's invaluable! ❤️
The text was updated successfully, but these errors were encountered: