Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deinflect): Only deinflect って and friends to く for 行く #1974

Merged
merged 6 commits into from
Feb 23, 2024
Merged

fix(deinflect): Only deinflect って and friends to く for 行く #1974

merged 6 commits into from
Feb 23, 2024

Conversation

bruno-queiroz
Copy link
Contributor

@bruno-queiroz bruno-queiroz commented Feb 14, 2024 •
edited by melink14
Loading

We don't match the kana form in order to not incorrectly match いって to 往く, which would be incorrect. 行く is almost always written with kanji so it seems like the right tradeoff.

Fixes #1920

melink14
melink14 requested changes Feb 16, 2024
View reviewed changes
Copy link
Owner

@melink14 melink14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two comments which should answer the questions you had in the PR description. Sorry if my previous explanations were unclear. (Also sorry that this part of the code base hasn't been cleaned up to be easier to edit)

extension/data/deinflect.dat Outdated Show resolved Hide resolved
extension/data/deinflect.dat Outdated Show resolved Hide resolved
@bruno-queiroz bruno-queiroz changed the title Fix く inflections fix(deinflect): Fix く inflections Feb 19, 2024
@bruno-queiroz
Copy link
Contributor Author

bruno-queiroz commented Feb 19, 2024 •
edited
Loading

Left two comments which should answer the questions you had in the PR description. Sorry if my previous explanations were unclear. (Also sorry that this part of the code base hasn't been cleaned up to be easier to edit)

No problem, thanks for explaining and helping me.

@bruno-queiroz
Copy link
Contributor Author

Why did the tests failed this time? 🤔

@melink14
Copy link
Owner

Why did the tests failed this time? 🤔

Not sure; for now I'm just re-running them in case it was a fluke.

@melink14
Copy link
Owner

Why did the tests failed this time? 🤔

Not sure; for now I'm just re-running them in case it was a fluke.

Looks like that worked. I will lightly edit the PR title/description for style and then approve which will start the merge process. (The PR title and body become the commit message so they're a bit more important than in other repos)

@melink14 melink14 changed the title fix(deinflect): Fix く inflections fix(deinflect): Only deinflect って and friends to く for 行く Feb 23, 2024
@melink14
Copy link
Owner

@all-contributors please add @bruno-queiroz for code.

@allcontributors allcontributors bot mentioned this pull request Feb 23, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@melink14

I've put up a pull request to add @bruno-queiroz! 🎉

@mergify mergify bot merged commit 30a0e33 into melink14:main Feb 23, 2024
11 of 13 checks passed
mergify bot pushed a commit that referenced this pull request Feb 23, 2024
@allcontributors
docs: add bruno-queiroz as a contributor for code (#1982)
b9a1e99 
Adds @bruno-queiroz as a contributor for code.

This was requested by melink14 [in this comment](#1974 (comment))
@bruno-queiroz
Copy link
Contributor Author

Thank you 😁

melink14 pushed a commit that referenced this pull request Feb 26, 2024
@semantic-release-bot
chore(release): 2.5.45
bcd08b1 
## [2.5.45](v2.5.44...v2.5.45) (2024-02-26)

### Bug Fixes

* **deinflect:**  Only deinflect って and friends to く for 行く ([#1974](#1974)) ([30a0e33](30a0e33)), closes [#1920](#1920)
* **dict:** Update dictionaries to latest versions ([#1986](#1986)) ([d628c4b](d628c4b))
@melink14
Copy link
Owner

🎉 This PR is included in version 2.5.45 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melink14 melink14 melink14 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rikaikun thinks って can be an inflection of く verbs
2 participants
@bruno-queiroz @melink14