Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Migrate from webpack to snowpack for build step #583

Merged
merged 1 commit into from
Jul 16, 2021
Merged

refactor!: Migrate from webpack to snowpack for build step #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,25 @@
"webextensions": true
},
"plugins": ["eslint-plugin-tsdoc", "sort-imports-es6-autofix"],
"ignorePatterns": "dist",
"ignorePatterns": ["dist"],
"rules": {
"tsdoc/syntax": "error",
"linebreak-style": ["error", "unix"],
"no-tabs": "error",
"sort-imports-es6-autofix/sort-imports-es6": "error",
"node/no-unpublished-import": "off",
"unicode-bom": "error",
"promise/prefer-await-to-then": "error",
"@typescript-eslint/unbound-method": "error",
"curly": "error"
},
"overrides": [
{
"files": ["**/*.ts", "**/*.js"],
"files": ["**/*.ts"],
"parserOptions": {
"project": "./tsconfig.json"
},
"rules": {
"tsdoc/syntax": "error",
"@typescript-eslint/unbound-method": "error"
}
}
]
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@ jobs:
node-version: '14'
- run: npm ci
- run: npm run lint
- run: npm run checktypes
- run: npm run build
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
node_modules
dist
.vscode
2 changes: 1 addition & 1 deletion extension/background.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<html>
<head>
<script src="background.js"></script>
<script type="module" src="background.js"></script>
</head>
</html>
1 change: 1 addition & 0 deletions extension/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"manifest_version": 2,
"name": "rikaikun",
"version": "1.2.6",
"minimum_chrome_version": "80",
"description": "rikaikun shows the reading and English definition of Japanese words when you hover over Japanese text in the browser.",
"icons": {
"48": "images/icon48.png",
Expand Down
4 changes: 2 additions & 2 deletions extension/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ type OptionEvent = {
__update: Partial<Config>;
};

export class OptionsForm extends LitElement {
class OptionsForm extends LitElement {
private content: Promise<TemplateResult> = this.fetchAndRender();

render() {
Expand Down Expand Up @@ -393,7 +393,7 @@ customElements.define('options-form', OptionsForm);

// TODO(https://github.com/Victor-Bernabe/lit-toast/issues/2):
// Remove this if the component supports types directly.
interface LitToast {
interface LitToast extends Element {
show(text: string, duration: number): Promise<void>;
}
declare global {
Expand Down
Loading